jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename SonarDiagnosticActivity to FlipperDiagnosticActivity

Browse Source 
Summary: Per title.

Reviewed By: danielbuechele

Differential Revision: D9966619

fbshipit-source-id: 52934813903f1d48c1ee35938848320b54a50a0f
This commit is contained in:
Pascal Hartig
2018-09-21 11:35:25 -07:00
committed by Facebook Github Bot
parent ab4f4ed02b
commit 8780cff8ca
6 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/sample/AndroidManifest.xml
View File

@@ -24,7 +24,7 @@
<category android:name="android.intent.category.LAUNCHER"/> <category android:name="android.intent.category.LAUNCHER"/>
</intent-filter> </intent-filter>
</activity> </activity>
<activity android:name="com.facebook.flipper.android.diagnostics.SonarDiagnosticActivity" <activity android:name="com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity"
android:exported="true"/> android:exported="true"/>
</application> </application>

4
android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java
View File

@@ -12,7 +12,7 @@ import com.facebook.litho.annotations.LayoutSpec;
import com.facebook.litho.annotations.OnCreateLayout; import com.facebook.litho.annotations.OnCreateLayout;
import com.facebook.litho.annotations.OnEvent; import com.facebook.litho.annotations.OnEvent;
import com.facebook.litho.widget.Text; import com.facebook.litho.widget.Text;
import com.facebook.flipper.android.diagnostics.SonarDiagnosticActivity; import com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity;
import java.io.IOException; import java.io.IOException;
import okhttp3.Call; import okhttp3.Call;
@@ -109,7 +109,7 @@ public class RootComponentSpec {
@OnEvent(ClickEvent.class) @OnEvent(ClickEvent.class)
static void openDiagnostics(final ComponentContext c) { static void openDiagnostics(final ComponentContext c) {
Intent intent = new Intent(c, SonarDiagnosticActivity.class); Intent intent = new Intent(c, FlipperDiagnosticActivity.class);
c.startActivity(intent); c.startActivity(intent);
} }
} }

2
android/src/main/java/com/facebook/flipper/android/diagnostics/AndroidManifest.xml
View File

@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?> <?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"> <manifest xmlns:android="http://schemas.android.com/apk/res/android">
<application> <application>
<activity android:name="com.facebook.flipper.android.diagnostics.SonarDiagnosticActivity" <activity android:name="com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity"
android:exported="true" /> android:exported="true" />
</application> </application>
</manifest> </manifest>

2
android/src/main/java/com/facebook/flipper/android/diagnostics/SonarDiagnosticActivity.java → android/src/main/java/com/facebook/flipper/android/diagnostics/FlipperDiagnosticActivity.java
View File

@@ -14,7 +14,7 @@ import android.view.View;
import android.widget.TextView; import android.widget.TextView;
import android.widget.ScrollView; import android.widget.ScrollView;
public class SonarDiagnosticActivity extends Activity implements FlipperStateUpdateListener { public class FlipperDiagnosticActivity extends Activity implements FlipperStateUpdateListener {
private TextView summaryView; private TextView summaryView;
private TextView logView; private TextView logView;

2
docs/getting-started.md
View File

@@ -33,7 +33,7 @@ Add the following permissions to your AndroidManifest.xml. The SDK needs these t
It's recommended that you add the following activity to the manifest too, which can help diagnose integration issues and other problems: It's recommended that you add the following activity to the manifest too, which can help diagnose integration issues and other problems:
```xml ```xml
<activity android:name="com.facebook.sonar.android.diagnostics.SonarDiagnosticActivity" <activity android:name="com.facebook.sonar.android.diagnostics.FlipperDiagnosticActivity"
android:exported="true"/> android:exported="true"/>
``` ```

4
docs/troubleshooting.md
View File

@@ -37,9 +37,9 @@ The Flipper SDK includes an in-app connection diagnostics screen to help you dia
Replace `<APP_PACKAGE>` below with the package name of your app, e.g. `com.facebook.flipper.sample`. Replace `<APP_PACKAGE>` below with the package name of your app, e.g. `com.facebook.flipper.sample`.
On a terminal, run the following: On a terminal, run the following:
```bash ```bash
adb shell am start -n <APP_PACKAGE>/com.facebook.sonar.android.diagnostics.SonarDiagnosticActivity adb shell am start -n <APP_PACKAGE>/com.facebook.sonar.android.diagnostics.FlipperDiagnosticActivity
``` ```
This will only work if you added `SonarDiagnosticActivity` to your `AndroidManifest.xml`. See [getting started](getting-started.html) for help. This will only work if you added `FlipperDiagnosticActivity` to your `AndroidManifest.xml`. See [getting started](getting-started.html) for help.
#### iOS #### iOS
You'll need to manually add this [ViewController](https://github.com/facebook/flipper/blob/master/iOS/SonarKit/FlipperDiagnosticsViewController.m) to your app to see the in-app diagnostics. You'll need to manually add this [ViewController](https://github.com/facebook/flipper/blob/master/iOS/SonarKit/FlipperDiagnosticsViewController.m) to your app to see the in-app diagnostics.