Fix require monkey-patching in electron build
Summary:
In D39311893 (094c5bdfdd) we started monkey-patching `require` to resolve global dependencies in the plugins. Apparently, patching `globalThis.require` did not work in the electron env. On my local machine it kept working because I had the experimental `flipper-server` feature enabled which embeds flipper-server into the electron build. In flipper-server we properly patch `require` via `Module.prototype.require` which affected the global require in electron.
With this fix we now properly patch require in electron via Module.prototype.require all the time
Changelog: Fix plugin loading with experimental flipper-server disabled
Reviewed By: nikoant
Differential Revision: D39633821
fbshipit-source-id: 9554f643c625620d116075ae87f573d8447850f6
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d600203627
commit
8716761cb3
@@ -19,6 +19,7 @@ export interface GlobalObject {
|
||||
antd: any;
|
||||
emotion_styled: any;
|
||||
antdesign_icons: any;
|
||||
ReactJsxRuntime: any;
|
||||
}
|
||||
|
||||
declare module globalThis {
|
||||
@@ -32,6 +33,7 @@ declare module globalThis {
|
||||
let antd: any;
|
||||
let emotion_styled: any;
|
||||
let antdesign_icons: any;
|
||||
let ReactJsxRuntime: any;
|
||||
}
|
||||
|
||||
export const setGlobalObject = (replacements: GlobalObject) => {
|
||||
|
||||
Reference in New Issue
Block a user