jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Xcode version check (#3428)

Browse Source 
Summary:
Fixes https://github.com/facebook/flipper/issues/3396 - the Xcode version mismatch check has been broken since 0.132.0.

## Changelog

Fixed Xcode version mismatch check

Pull Request resolved: https://github.com/facebook/flipper/pull/3428

Test Plan: No existing test, manually tested locally on macOS 11.6.3 via `yarn start` when launching the Simulator directly or via `yarn react-native run-ios` in an RN project

Reviewed By: lblasa, mweststrate

Differential Revision: D34139471

Pulled By: lawrencelomax

fbshipit-source-id: 97920de5c463b366ef7ecaef0441ee37debe5d46
This commit is contained in:
Liam Jones
2022-02-10 01:47:04 -08:00
committed by Facebook GitHub Bot
parent de99cf763c
commit 8696349593
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx
View File

@@ -195,7 +195,7 @@ export class IOSDeviceManager {
let {stdout: xcodeCLIVersion} = await exec('xcode-select -p'); let {stdout: xcodeCLIVersion} = await exec('xcode-select -p');
xcodeCLIVersion = xcodeCLIVersion!.toString().trim(); xcodeCLIVersion = xcodeCLIVersion!.toString().trim();
const {stdout} = await exec( const {stdout} = await exec(
"pgrep Simulator | xargs ps | grep Simulator.app | awk '{print $NF}'", "pgrep Simulator | xargs ps -o command | grep -v grep | grep Simulator.app | awk '{print $1}'",
); );
for (const runningSimulatorApp of stdout!.toString().split('\n')) { for (const runningSimulatorApp of stdout!.toString().split('\n')) {
if (!runningSimulatorApp) { if (!runningSimulatorApp) {