Make deeplinks manual- and unittestable

Summary: This diff makes sure we can manually & unit tests deeplinks more easily, by introducing a dialog in which a deeplink can be entered manually and extracting deeplink handling logic from the application dispatcher.

Reviewed By: jknoxville

Differential Revision: D29760933

fbshipit-source-id: 0fc8f577204ecdd278716853b87786557a6e2194
This commit is contained in:
Michel Weststrate
2021-07-22 04:16:01 -07:00
committed by Facebook GitHub Bot
parent fe96c9b6d2
commit 860f723521
6 changed files with 256 additions and 81 deletions

View File

@@ -8,36 +8,16 @@
*/
import {remote, ipcRenderer, IpcRendererEvent} from 'electron';
import {
ACTIVE_SHEET_SIGN_IN,
setActiveSheet,
setPastedToken,
toggleAction,
} from '../reducers/application';
import {Group, SUPPORTED_GROUPS} from '../reducers/supportForm';
import {Store} from '../reducers/index';
import {Logger} from '../fb-interfaces/Logger';
import {parseFlipperPorts} from '../utils/environmentVariables';
import {
importDataToStore,
importFileToStore,
IMPORT_FLIPPER_TRACE_EVENT,
} from '../utils/exportData';
import {tryCatchReportPlatformFailures} from '../utils/metrics';
import {selectPlugin} from '../reducers/connections';
export const uriComponents = (url: string): Array<string> => {
if (!url) {
return [];
}
const match: Array<string> | undefined | null = url.match(
/^flipper:\/\/([^\/]*)\/([^\/\?]*)\/?(.*)$/,
);
if (match) {
return match.map(decodeURIComponent).slice(1).filter(Boolean);
}
return [];
};
import {handleDeeplink} from '../deeplink';
import {message} from 'antd';
export default (store: Store, _logger: Logger) => {
const currentWindow = remote.getCurrentWindow();
@@ -77,66 +57,13 @@ export default (store: Store, _logger: Logger) => {
ipcRenderer.on(
'flipper-protocol-handler',
(_event: IpcRendererEvent, query: string) => {
const uri = new URL(query);
if (uri.protocol !== 'flipper:') {
return;
}
if (uri.pathname.match(/^\/*import\/*$/)) {
const url = uri.searchParams.get('url');
store.dispatch(toggleAction('downloadingImportData', true));
return (
typeof url === 'string' &&
fetch(url)
.then((res) => res.text())
.then((data) => importDataToStore(url, data, store))
.then(() => {
store.dispatch(toggleAction('downloadingImportData', false));
})
.catch((e: Error) => {
console.error(e);
store.dispatch(toggleAction('downloadingImportData', false));
})
);
} else if (uri.pathname.match(/^\/*support-form\/*$/)) {
const formParam = uri.searchParams.get('form');
const grp = deeplinkFormParamToGroups(formParam);
if (grp) {
grp.handleSupportFormDeeplinks(store);
}
return;
} else if (uri.pathname.match(/^\/*login\/*$/)) {
const token = uri.searchParams.get('token');
store.dispatch(setPastedToken(token ?? undefined));
if (store.getState().application.activeSheet !== ACTIVE_SHEET_SIGN_IN) {
store.dispatch(setActiveSheet(ACTIVE_SHEET_SIGN_IN));
}
return;
}
const match = uriComponents(query);
if (match.length > 1) {
// flipper://<client>/<pluginId>/<payload>
return store.dispatch(
selectPlugin({
selectedApp: match[0],
selectedPlugin: match[1],
deepLinkPayload: match[2],
}),
);
}
handleDeeplink(store, query).catch((e) => {
console.warn('Failed to handle deeplink', query, e);
message.error(`Failed to handle deeplink '${query}': ${e}`);
});
},
);
function deeplinkFormParamToGroups(
formParam: string | null,
): Group | undefined {
if (!formParam) {
return undefined;
}
return SUPPORTED_GROUPS.find((grp) => {
return grp.deeplinkSuffix.toLowerCase() === formParam.toLowerCase();
});
}
ipcRenderer.on(
'open-flipper-file',
(_event: IpcRendererEvent, url: string) => {