Make deeplinks manual- and unittestable

Summary: This diff makes sure we can manually & unit tests deeplinks more easily, by introducing a dialog in which a deeplink can be entered manually and extracting deeplink handling logic from the application dispatcher. Reviewed By: jknoxville Differential Revision: D29760933 fbshipit-source-id: 0fc8f577204ecdd278716853b87786557a6e2194
2021-07-22 04:16:01 -07:00
parent fe96c9b6d2
commit 860f723521
6 changed files with 256 additions and 81 deletions
--- a/desktop/app/src/tests/deeplink.node.tsx
+++ b/desktop/app/src/tests/deeplink.node.tsx
@@ -0,0 +1,95 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+jest.useFakeTimers();
+
+import React from 'react';
+import {renderMockFlipperWithPlugin} from '../test-utils/createMockFlipperWithPlugin';
+import {
+  _SandyPluginDefinition,
+  PluginClient,
+  TestUtils,
+  usePlugin,
+  createState,
+  useValue,
+} from 'flipper-plugin';
+import {handleDeeplink} from '../deeplink';
+
+test('Triggering a deeplink will work', async () => {
+  const linksSeen: any[] = [];
+
+  const plugin = (client: PluginClient) => {
+    const linkState = createState('');
+    client.onDeepLink((link) => {
+      linksSeen.push(link);
+      linkState.set(String(link));
+    });
+    return {
+      linkState,
+    };
+  };
+
+  const definition = new _SandyPluginDefinition(
+    TestUtils.createMockPluginDetails(),
+    {
+      plugin,
+      Component() {
+        const instance = usePlugin(plugin);
+        const linkState = useValue(instance.linkState);
+        return <h1>{linkState || 'world'}</h1>;
+      },
+    },
+  );
+  const {renderer, client, store} = await renderMockFlipperWithPlugin(
+    definition,
+  );
+
+  expect(linksSeen).toEqual([]);
+
+  await handleDeeplink(
+    store,
+    `flipper://${client.query.app}/${definition.id}/universe`,
+  );
+
+  jest.runAllTimers();
+  expect(linksSeen).toEqual(['universe']);
+  expect(renderer.baseElement).toMatchInlineSnapshot(`
+    <body>
+      <div>
+        <div
+          class="css-1x2cmzz-SandySplitContainer e1hsqii10"
+        >
+          <div />
+          <div
+            class="css-1knrt0j-SandySplitContainer e1hsqii10"
+          >
+            <div
+              class="css-1woty6b-Container"
+            >
+              <h1>
+                universe
+              </h1>
+            </div>
+            <div
+              class="css-724x97-View-FlexBox-FlexRow"
+              id="detailsSidebar"
+            />
+          </div>
+        </div>
+      </div>
+    </body>
+  `);
+});
+
+test('Will throw error on invalid deeplinks', async () => {
+  // flipper:///support-form/?form=litho
+  expect(() =>
+    handleDeeplink(undefined as any, `flipper://test`),
+  ).rejects.toThrowErrorMatchingInlineSnapshot(`"Unknown deeplink"`);
+});