From 860cf332e107bca873a6a441b0cce19475e8bcf9 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Thu, 14 Jul 2022 10:40:43 -0700 Subject: [PATCH] Do not disconnect when there's a 'send' error Summary: Historically, RSocket used to raise an error when there was an error during send, most likely because the connection was dead. With WS, this is no longer the case. WS connection issues are raised through the according handlers. Reviewed By: passy Differential Revision: D37825821 fbshipit-source-id: 7fcda8cf26fb42eb0d8ca03b62482f11c931777f --- desktop/flipper-frontend-core/src/AbstractClient.tsx | 3 --- 1 file changed, 3 deletions(-) diff --git a/desktop/flipper-frontend-core/src/AbstractClient.tsx b/desktop/flipper-frontend-core/src/AbstractClient.tsx index c87413348..87b59145a 100644 --- a/desktop/flipper-frontend-core/src/AbstractClient.tsx +++ b/desktop/flipper-frontend-core/src/AbstractClient.tsx @@ -379,9 +379,6 @@ export default abstract class AbstractClient extends EventEmitter { }); } } catch (error) { - // This is only called if the connection is dead. Not in expected - // and recoverable cases like a missing receiver/method. - this.disconnect(); reject(new Error('Unable to send, connection error: ' + error)); } } else {