Change performAndReportError to handle exception pointers

Summary: Since plugins aren't under our control, they might throw exception pointers. We can still extract the useful info in this case.

Reviewed By: passy

Differential Revision: D14244362

fbshipit-source-id: 5f18100c08160e7514b3fd88ec47809cb37e9770

xplat/Flipper/FlipperClient.cpp

@@ -302,15 +302,10 @@ void FlipperClient::performAndReportError(const std::function<void()>& func) {
   try {
     func();
   } catch (std::exception& e) {
-    if (connected_) {
+    handleError(e);
-      std::string callstack = this->callstack();
+  } catch (std::exception* e) {
-      dynamic message = dynamic::object(
+    if (e) {
-          "error",
+      handleError(*e);
-          dynamic::object("message", e.what())("stacktrace", callstack)(
-              "name", e.what()));
-      socket_->sendMessage(message);
-    } else {
-      log("Error: " + std::string(e.what()));
     }
   } catch (...) {
     // Generic catch block for the exception of type not belonging to
@@ -320,6 +315,19 @@ void FlipperClient::performAndReportError(const std::function<void()>& func) {
 #endif
 }
 
+void FlipperClient::handleError(std::exception& e) {
+  if (connected_) {
+    std::string callstack = this->callstack();
+    dynamic message = dynamic::object(
+        "error",
+        dynamic::object("message", e.what())("stacktrace", callstack)(
+            "name", e.what()));
+    socket_->sendMessage(message);
+  } else {
+    log("Error: " + std::string(e.what()));
+  }
+}
+
 std::string FlipperClient::getState() {
   return flipperState_->getState();
 }

xplat/Flipper/FlipperClient.h

@@ -110,6 +110,7 @@ class FlipperClient : public FlipperConnectionManager::Callbacks {
   void disconnect(std::shared_ptr<FlipperPlugin> plugin);
   void startBackgroundPlugins();
   std::string callstack();
+  void handleError(std::exception& e);
 };
 
 } // namespace flipper