diff --git a/src/plugins/navigation/__tests__/testNavigationPlugin.node.js b/src/plugins/navigation/__tests__/testNavigationPlugin.node.js index bab2dfcd2..1642dd230 100644 --- a/src/plugins/navigation/__tests__/testNavigationPlugin.node.js +++ b/src/plugins/navigation/__tests__/testNavigationPlugin.node.js @@ -12,14 +12,12 @@ import type {PersistedState} from '../'; function constructPersistedStateMock(): PersistedState { return { - bookmarks: [], navigationEvents: [], }; } function constructPersistedStateMockWithEvents(): PersistedState { return { - bookmarks: [], navigationEvents: [ { uri: 'mock://this_is_a_mock_uri/mock/1', diff --git a/src/plugins/navigation/components/BookmarksSidebar.js b/src/plugins/navigation/components/BookmarksSidebar.js index 7c681871d..791cc93b7 100644 --- a/src/plugins/navigation/components/BookmarksSidebar.js +++ b/src/plugins/navigation/components/BookmarksSidebar.js @@ -11,7 +11,7 @@ import {DetailSidebar, FlexCenter, styled, colors} from 'flipper'; import type {Bookmark} from '../'; type Props = {| - bookmarks: Array, + bookmarks: Map, onNavigate: string => void, |}; @@ -57,11 +57,11 @@ export default (props: Props) => { const {bookmarks, onNavigate} = props; return ( - {bookmarks.length === 0 ? ( + {bookmarks.size === 0 ? ( No Bookmarks ) : ( - {bookmarks.map(bookmark => ( + {[...bookmarks.values()].map(bookmark => (
void, onFavorite: (query: string) => void, @@ -52,7 +53,7 @@ const NavigationInfoBoxContainer = styled('div')({ }); export default (props: Props) => { - const {uri} = props; + const {uri, isBookmarked} = props; if (uri == null) { return ( @@ -65,7 +66,7 @@ export default (props: Props) => {
props.onFavorite(uri)} /> diff --git a/src/plugins/navigation/components/SaveBookmarkDialog.js b/src/plugins/navigation/components/SaveBookmarkDialog.js index 057e328a7..3009d673e 100644 --- a/src/plugins/navigation/components/SaveBookmarkDialog.js +++ b/src/plugins/navigation/components/SaveBookmarkDialog.js @@ -7,12 +7,15 @@ */ import {Button, FlexColumn, Input, Sheet, styled} from 'flipper'; +import {useState} from 'react'; + +import type {Bookmark} from '../'; type Props = {| uri: ?string, shouldShow: boolean, onHide: ?() => void, - onSubmit: ?(uri: string) => void, + onSubmit: Bookmark => void, |}; const Container = styled(FlexColumn)({ @@ -45,6 +48,7 @@ const NameInput = styled(Input)({ export default (props: Props) => { const {shouldShow, onHide, onSubmit, uri} = props; + const [commonName, setCommonName] = useState(''); if (uri == null || !shouldShow) { return null; } else { @@ -54,19 +58,30 @@ export default (props: Props) => { return ( Save to bookmarks... - + setCommonName(event.target.value)} + /> {uri} -