jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DataTable tweaks

Browse Source 
Summary: Found a small issue in the column width calculation where initial invisible columns still got space assigned.

Reviewed By: passy

Differential Revision: D28221659

fbshipit-source-id: ef052533bc37bc833bab72979803ce36bcf50e61
This commit is contained in:
Michel Weststrate
2021-05-06 04:26:41 -07:00
committed by Facebook GitHub Bot
parent 23402dfff6
commit 84d65b1a77
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
desktop/flipper-plugin/src/ui/DataList.tsx
View File

@@ -94,6 +94,9 @@ export const DataList: React.FC<DataListProps<any>> = function DataList<
const tableManagerRef = tableProps.tableManagerRef ?? createRef<undefined | DataTableManager<T>>();
useAssertStableRef(baseSelection, 'selection');
useAssertStableRef(onRenderItem, 'onRenderItem');
useAssertStableRef(enableArrow, 'enableArrow');
// create local selection atom if none provided
// eslint-disable-next-line
const selection = baseSelection ?? useState(() => createState<string|undefined>())[0];

5
desktop/flipper-plugin/src/ui/data-table/DataTableManager.tsx
View File

@@ -443,8 +443,9 @@ function computeInitialColumns(
columns: DataTableColumn<any>[],
): DataTableColumn<any>[] {
const visibleColumnCount = columns.filter((c) => c.visible !== false).length;
const columnsWithoutWidth = columns.filter((c) => c.width === undefined)
.length;
const columnsWithoutWidth = columns.filter(
(c) => c.visible !== false && c.width === undefined,
).length;
return columns.map((c) => ({
...c,