jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix unit test setup

Browse Source 
Summary:
There were still some tests with the internal test runner which
would fail in open source and with Gradle.

Reviewed By: priteshrnandgaonkar

Differential Revision: D10145759

fbshipit-source-id: 99915548441e426b88b1fa6ace1e852775e2a770
This commit is contained in:
Pascal Hartig
2018-10-02 09:23:40 -07:00
committed by Facebook Github Bot
parent b6445bb961
commit 8456a13ee6
3 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
android/build.gradle
View File

@@ -30,6 +30,7 @@ android {
test { test {
java { java {
exclude 'com/facebook/sonar/plugins/facebook/**' exclude 'com/facebook/sonar/plugins/facebook/**'
exclude 'com/facebook/flipper/plugins/facebook/**'
} }
} }
} }

4
android/src/test/java/com/facebook/sonar/plugins/console/ConsoleFlipperPluginTest.java
View File

@@ -13,12 +13,12 @@ import static org.hamcrest.MatcherAssert.assertThat;
import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperObject;
import com.facebook.flipper.testing.FlipperConnectionMock; import com.facebook.flipper.testing.FlipperConnectionMock;
import com.facebook.flipper.testing.FlipperResponderMock; import com.facebook.flipper.testing.FlipperResponderMock;
import com.facebook.testing.robolectric.v3.WithTestDefaultsRunner; import org.robolectric.RobolectricTestRunner;
import org.junit.Before; import org.junit.Before;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
@RunWith(WithTestDefaultsRunner.class) @RunWith(RobolectricTestRunner.class)
public class ConsoleFlipperPluginTest { public class ConsoleFlipperPluginTest {
FlipperConnectionMock connection; FlipperConnectionMock connection;

4
android/src/test/java/com/facebook/sonar/plugins/inspector/InspectorFlipperPluginTest.java
View File

@@ -26,7 +26,7 @@ import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin.TouchOverla
import com.facebook.flipper.plugins.inspector.descriptors.ApplicationDescriptor; import com.facebook.flipper.plugins.inspector.descriptors.ApplicationDescriptor;
import com.facebook.flipper.testing.FlipperConnectionMock; import com.facebook.flipper.testing.FlipperConnectionMock;
import com.facebook.flipper.testing.FlipperResponderMock; import com.facebook.flipper.testing.FlipperResponderMock;
import com.facebook.testing.robolectric.v3.WithTestDefaultsRunner; import org.robolectric.RobolectricTestRunner;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays; import java.util.Arrays;
import java.util.Collections; import java.util.Collections;
@@ -39,7 +39,7 @@ import org.robolectric.RuntimeEnvironment;
import javax.annotation.Nullable; import javax.annotation.Nullable;
@RunWith(WithTestDefaultsRunner.class) @RunWith(RobolectricTestRunner.class)
public class InspectorFlipperPluginTest { public class InspectorFlipperPluginTest {
private MockApplicationDescriptor mApplicationDescriptor; private MockApplicationDescriptor mApplicationDescriptor;