jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge internal and external troubleshooting pages into one with optional internal-only content

Browse Source 
Summary: Merged internal and external troubleshooting pages into one with optional internal-only content

Reviewed By: mweststrate

Differential Revision: D23651656

fbshipit-source-id: 330dd4b5cb49ae403a0a3760c1e23e30e56ad190
This commit is contained in:
Anton Nikolaev
2020-09-14 03:50:27 -07:00
committed by Facebook GitHub Bot
parent 12d7b48443
commit 8425db7b8b
4 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/getting-started/index.mdx
View File

@@ -2,7 +2,6 @@
id: index id: index
title: Desktop App title: Desktop App
--- ---
import useBaseUrl from '@docusaurus/useBaseUrl';
import FBContent from '../../website/src/components/FBContent'; import FBContent from '../../website/src/components/FBContent';
Flipper helps you debug Android and iOS apps running in an emulator/simulator or connected physical development devices. Flipper consists of two parts: Flipper helps you debug Android and iOS apps running in an emulator/simulator or connected physical development devices. Flipper consists of two parts:

7
docs/troubleshooting.mdx
View File

@@ -5,6 +5,7 @@ sidebar_label: Troubleshooting Issues
--- ---
import useBaseUrl from '@docusaurus/useBaseUrl'; import useBaseUrl from '@docusaurus/useBaseUrl';
import Link from '@docusaurus/Link'; import Link from '@docusaurus/Link';
import FBContent from '../website/src/components/FBContent';
We hope that flipper works well out of the box, but the software is a work in progress and problems will occur. Below are some known issues and steps you can take to try to resolve them. We hope that flipper works well out of the box, but the software is a work in progress and problems will occur. Below are some known issues and steps you can take to try to resolve them.
@@ -165,3 +166,9 @@ If you experience errors such as `Undefined symbol: associated type descriptor f
<img alt="Screenshot showing the places mentioned in the last steps" src={useBaseUrl("img/troubleshooting-react-native-ios-swift-2.png")} /> <img alt="Screenshot showing the places mentioned in the last steps" src={useBaseUrl("img/troubleshooting-react-native-ios-swift-2.png")} />
1. Now you can run your build normally. 1. Now you can run your build normally.
## Facebook-specific issues
<FBContent
internal={() => require('./fb/troubleshooting.mdx')}
external={"Luckily you're in Open Source, so you don't have to worry about this stuff."} />

1
website/sidebars.js
View File

@@ -98,7 +98,6 @@ module.exports = {
}, },
'fb-internal': { 'fb-internal': {
'FB Internal': fbInternalOnly([ 'FB Internal': fbInternalOnly([
'fb/troubleshooting',
'fb/Add-flipper-to-android-app', 'fb/Add-flipper-to-android-app',
'fb/Adding-flipper-to-ios-app', 'fb/Adding-flipper-to-ios-app',
'fb/LauncherConfig', 'fb/LauncherConfig',

3
website/src/components/FBContent.jsx
View File

@@ -17,6 +17,9 @@ function createElement(createElement) {
if (React.isValidElement(createElement)) { if (React.isValidElement(createElement)) {
return createElement; return createElement;
} }
if (typeof createElement === 'string') {
return createElement;
}
const element = createElement(); const element = createElement();
if (React.isValidElement(element)) { if (React.isValidElement(element)) {
return element; return element;