diff --git a/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx b/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx index 988f98d44..b8a2af494 100644 --- a/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx +++ b/desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx @@ -21,14 +21,12 @@ import {getRenderHostInstance} from 'flipper-frontend-core'; import React, {useCallback, useEffect, useMemo, useState} from 'react'; import {useDispatch, useStore} from '../utils/useStore'; import config from '../fb-stubs/config'; -import {isConnected, currentUser, logoutUser} from '../fb-stubs/user'; -import {showLoginDialog} from '../chrome/fb-stubs/SignInSheet'; -import {Avatar, Badge, Button, Menu, Modal, Popover, Tooltip} from 'antd'; +import {currentUser, isConnected, logoutUser} from '../fb-stubs/user'; +import {Badge, Button, Menu, Modal} from 'antd'; import { BellOutlined, BugOutlined, LayoutOutlined, - LoginOutlined, MobileOutlined, RocketOutlined, SettingOutlined, @@ -110,6 +108,8 @@ export const Navbar = withTrackingScope(function Navbar({ )} + + - {config.showLogin && } + @@ -336,10 +336,12 @@ export function NavbarButton({ disabled = false, flipIcon = false, zIndex, + colorOverride, }: { icon: (props: any) => any; label: string; // TODO remove optional + colorOverride?: string; zIndex?: number; onClick?: () => void; toggled?: boolean; @@ -367,7 +369,7 @@ export function NavbarButton({ disabled={disabled}> {label} @@ -401,60 +403,21 @@ export function NavbarButton({ } } -function LoginConnectivityButton() { - const loggedIn = useValue(currentUser()); - const user = useStore((state) => state.user); - - const profileUrl = user?.profile_picture?.uri; - const [showLogout, setShowLogout] = useState(false); - const onHandleVisibleChange = useCallback( - (visible) => setShowLogout(visible), - [], - ); - +function NoConnectivityWarning() { const connected = useValue(isConnected()); if (!connected) { return ( - - - + ); } - return loggedIn ? ( - { - onHandleVisibleChange(false); - await logoutUser(); - }}> - Log Out - - } - trigger="click" - placement="bottom" - visible={showLogout} - overlayStyle={{padding: 0}} - onVisibleChange={onHandleVisibleChange}> - - - - - ) : ( - - ); + return null; } const menu = css` @@ -593,6 +556,7 @@ function ExtrasMenu() { const settings = useStore((state) => state.settingsState); const {showWelcomeAtStartup} = settings; const [welcomeVisible, setWelcomeVisible] = useState(showWelcomeAtStartup); + const loggedIn = useValue(currentUser()); return ( <> @@ -655,6 +619,11 @@ function ExtrasMenu() { setWelcomeVisible(true)}> Help + {config.showLogin && loggedIn && ( + await logoutUser()}> + Logout + + )}