From 82f4d4ad958a202405bec7f6cbed3670959c1f5e Mon Sep 17 00:00:00 2001
From: Pascal Hartig <realpassy@fb.com>
Date: Fri, 18 Jan 2019 07:58:27 -0800
Subject: [PATCH] Add --no-updater flag

Summary: Provide a `--no-updater` option that disables the in-app auto updater when passed.

Reviewed By: jknoxville

Differential Revision: D13713919

fbshipit-source-id: 49a647105fea1efa23f653e4a6ed452b3489879b
---
 scripts/start-dev-server.js                      |  1 +
 src/__tests__/__snapshots__/App.electron.js.snap |  3 ---
 src/chrome/TitleBar.js                           |  3 ++-
 src/utils/__mocks__/argvUtils.js                 |  8 ++++++++
 src/utils/argvUtils.js                           | 15 +++++++++++++++
 5 files changed, 26 insertions(+), 4 deletions(-)
 create mode 100644 src/utils/__mocks__/argvUtils.js
 create mode 100644 src/utils/argvUtils.js

diff --git a/scripts/start-dev-server.js b/scripts/start-dev-server.js
index 0c084bad8..f7898ee63 100644
--- a/scripts/start-dev-server.js
+++ b/scripts/start-dev-server.js
@@ -26,6 +26,7 @@ function launchElectron({bundleURL, electronURL}) {
   const args = [
     path.join(STATIC_DIR, 'index.js'),
     '--remote-debugging-port=9222',
+    ...process.argv,
   ];
 
   const proc = child.spawn(electronBinary, args, {
diff --git a/src/__tests__/__snapshots__/App.electron.js.snap b/src/__tests__/__snapshots__/App.electron.js.snap
index acf2059ca..e7774dc23 100644
--- a/src/__tests__/__snapshots__/App.electron.js.snap
+++ b/src/__tests__/__snapshots__/App.electron.js.snap
@@ -58,9 +58,6 @@ exports[`Empty app state matches snapshot 1`] = `
     <div
       className="css-12zzrdt"
     />
-    <div
-      className="css-1xcv92o"
-    />
     <div
       className="css-1cecbfb"
       onClick={[Function]}
diff --git a/src/chrome/TitleBar.js b/src/chrome/TitleBar.js
index dc2dc1eca..6ee52560c 100644
--- a/src/chrome/TitleBar.js
+++ b/src/chrome/TitleBar.js
@@ -27,6 +27,7 @@ import DevicesButton from './DevicesButton.js';
 import ScreenCaptureButtons from './ScreenCaptureButtons.js';
 import AutoUpdateVersion from './AutoUpdateVersion.js';
 import config from '../fb-stubs/config.js';
+import {isAutoUpdaterEnabled} from '../utils/argvUtils.js';
 
 const AppTitleBar = styled(FlexRow)(({focused}) => ({
   background: focused
@@ -65,7 +66,7 @@ class TitleBar extends Component<Props> {
         <DevicesButton />
         <ScreenCaptureButtons />
         <Spacer />
-        {process.platform === 'darwin' ? <AutoUpdateVersion /> : null}
+        {isAutoUpdaterEnabled() ? <AutoUpdateVersion /> : null}
         {config.bugReportButtonVisible && (
           <Button
             compact={true}
diff --git a/src/utils/__mocks__/argvUtils.js b/src/utils/__mocks__/argvUtils.js
new file mode 100644
index 000000000..088120de2
--- /dev/null
+++ b/src/utils/__mocks__/argvUtils.js
@@ -0,0 +1,8 @@
+/**
+ * Copyright 2018-present Facebook.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ * @format
+ */
+
+export const isAutoUpdaterEnabled = false;
diff --git a/src/utils/argvUtils.js b/src/utils/argvUtils.js
new file mode 100644
index 000000000..fab9de54f
--- /dev/null
+++ b/src/utils/argvUtils.js
@@ -0,0 +1,15 @@
+/**
+ * Copyright 2018-present Facebook.
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ * @format
+ */
+
+import electron from 'electron';
+import isProduction from './isProduction';
+
+export const isAutoUpdaterEnabled = () =>
+  // $FlowFixMe: argv is not included in the type defs.
+  !electron.remote.process.argv.includes('--no-updater') &&
+  isProduction() &&
+  process.platform === 'darwin';