From 828d56f617a84d84fbd5f5487b036f4636a4fc4e Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Fri, 2 Jun 2023 07:55:56 -0700
Subject: [PATCH] Kill PortForwardingApp on exit

Summary:
I noticed we were not killing the PortForwardingApp on exit.

This is not ideal.

So, use an exit hook to kill the app.

Reviewed By: passy

Differential Revision: D46392855

fbshipit-source-id: e2b75f76c9dfab0ff46df3ad2c94a1a523154b2a
---
 .../src/devices/ios/iOSDeviceManager.tsx                    | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx b/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx
index a96a16d5e..a467b1287 100644
--- a/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx
+++ b/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx
@@ -23,6 +23,7 @@ import {
 import {FlipperServerImpl} from '../../FlipperServerImpl';
 import {getFlipperServerConfig} from '../../FlipperServerConfig';
 import iOSCertificateProvider from './iOSCertificateProvider';
+import exitHook from 'exit-hook';
 
 export class IOSDeviceManager {
   private portForwarders: Array<ChildProcess> = [];
@@ -73,6 +74,11 @@ export class IOSDeviceManager {
         console.log(`[conn] Port forwarding app exited gracefully`);
       }
     });
+
+    exitHook(() => {
+      child.kill('SIGKILL');
+    });
+
     return child;
   }