jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up Flipper's iOS layout invalidation

Browse Source 
Summary:
This reverts D21285438 and patches some holes in the layout invalidation routines.

(I tried to use `didAddSubview:` and `willRemoveSubview:` but those are annoying for other reasons; for example, `willRemoveSubview:` can be called from within `dealloc` which is surprising. Also they still don't catch the case where subviews are being reordered.)

Reviewed By: Andrey-Mishanin

Differential Revision: D21512129

fbshipit-source-id: 1d9e8dac9333eddfae2309d446ef4de9e83220d6
This commit is contained in:
Adam Ernst
2020-05-12 05:52:36 -07:00
committed by Facebook GitHub Bot
parent 258b0314f5
commit 82898b784e
3 changed files with 59 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.mm
View File

@@ -384,10 +384,6 @@
});
}
- (void)invalidateRootNode {
[self invalidateNode:_rootNode];
}
- (void)_reportInvalidatedObjects {
NSMutableArray* nodes = [NSMutableArray new];
{ // scope mutex acquisition