Support screenshot buttons

Summary: Added Sandy styling to `CaptureButtons`, and converted to hooks while at it

Reviewed By: cekkaewnumchai

Differential Revision: D24538953

fbshipit-source-id: cfb9a9b856ada40eb96b77d2e5e6ea780971d0ce

desktop/app/src/chrome/ScreenCaptureButtons.tsx

@@ -7,28 +7,14 @@
  * @format
  */
 
+import {Button as AntButton, message} from 'antd';
 import {Button, ButtonGroup} from '../ui';
-import React, {Component} from 'react';
-import {connect} from 'react-redux';
+import React, {useState, useEffect, useCallback} from 'react';
 import path from 'path';
-import BaseDevice from '../devices/BaseDevice';
-import {State as Store} from '../reducers';
 import open from 'open';
 import {capture, CAPTURE_LOCATION, getFileName} from '../utils/screenshot';
-
-type OwnProps = {};
-
-type StateFromProps = {
-  selectedDevice: BaseDevice | null | undefined;
-};
-
-type DispatchFromProps = {};
-
-type State = {
-  recording: boolean;
-  recordingEnabled: boolean;
-  capturingScreenshot: boolean;
-};
+import {CameraOutlined, VideoCameraOutlined} from '@ant-design/icons';
+import {useStore} from '../utils/useStore';
 
 export async function openFile(path: string | null) {
   if (!path) {
@@ -42,111 +28,101 @@ export async function openFile(path: string | null) {
   }
 }
 
-type Props = OwnProps & StateFromProps & DispatchFromProps;
-class ScreenCaptureButtons extends Component<Props, State> {
-  videoPath: string | null | undefined;
+export default function ScreenCaptureButtons({useSandy}: {useSandy?: boolean}) {
+  const selectedDevice = useStore((state) => state.connections.selectedDevice);
+  const [isTakingScreenshot, setIsTakingScreenshot] = useState(false);
+  const [isRecordingAvailable, setIsRecordingAvailable] = useState(false);
+  const [isRecording, setIsRecording] = useState(false);
 
-  state = {
-    recording: false,
-    recordingEnabled: false,
-    capturingScreenshot: false,
-  };
-
-  componentDidMount() {
-    this.checkIfRecordingIsAvailable();
+  useEffect(() => {
+    let cancelled = false;
+    selectedDevice?.screenCaptureAvailable().then((result) => {
+      if (!cancelled) {
+        setIsRecordingAvailable(result);
       }
-
-  UNSAFE_componentWillReceiveProps(nextProps: Props) {
-    if (nextProps.selectedDevice !== this.props.selectedDevice) {
-      this.checkIfRecordingIsAvailable(nextProps);
-    }
-  }
-
-  checkIfRecordingIsAvailable = async (props: Props = this.props) => {
-    const {selectedDevice} = props;
-    const recordingEnabled = selectedDevice
-      ? await selectedDevice.screenCaptureAvailable()
-      : false;
-    this.setState({recordingEnabled});
-  };
-
-  captureScreenshot: Promise<void> | any = async () => {
-    const {selectedDevice} = this.props;
-    if (selectedDevice != null) {
-      await capture(selectedDevice)
-        .then(openFile)
-        .catch((e) => console.error('Taking screenshot failed:', e));
-    }
-  };
-
-  startRecording = async () => {
-    const {selectedDevice} = this.props;
-    if (!selectedDevice) {
-      return;
-    }
-    const videoPath = path.join(CAPTURE_LOCATION, getFileName('mp4'));
-    return selectedDevice.startScreenCapture(videoPath);
-  };
-
-  stopRecording = async () => {
-    const {selectedDevice} = this.props;
-    if (!selectedDevice) {
-      return;
-    }
-    const path = await selectedDevice.stopScreenCapture().catch((e) => {
-      console.error(e);
     });
-    path ? openFile(path) : 0;
+    return () => {
+      cancelled = true;
     };
+  }, [selectedDevice]);
 
-  onRecordingClicked = () => {
-    if (this.state.recording) {
-      this.stopRecording();
-      this.setState({
-        recording: false,
+  const handleScreenshot = useCallback(() => {
+    setIsTakingScreenshot(true);
+    capture(selectedDevice!)
+      .then(openFile)
+      .catch((e) => {
+        console.error('Taking screenshot failed:', e);
+        message.error('Taking screenshot failed:' + e);
+      })
+      .finally(() => {
+        setIsTakingScreenshot(false);
+      });
+  }, [selectedDevice]);
+  const handleRecording = useCallback(() => {
+    if (!selectedDevice) {
+      return;
+    }
+    if (!isRecording) {
+      setIsRecording(true);
+      const videoPath = path.join(CAPTURE_LOCATION, getFileName('mp4'));
+      selectedDevice.startScreenCapture(videoPath).catch((e) => {
+        console.error('Failed to start recording', e);
+        message.error('Failed to start recording' + e);
+        setIsRecording(false);
       });
     } else {
-      this.setState({
-        recording: true,
-      });
-      this.startRecording().catch((e) => {
-        this.setState({
-          recording: false,
-        });
-        console.error(e);
+      selectedDevice
+        .stopScreenCapture()
+        .then((path) => {
+          path && openFile(path);
+        })
+        .catch((e) => {
+          console.error('Failed to start recording', e);
+          message.error('Failed to start recording' + e);
+        })
+        .finally(() => {
+          setIsRecording(false);
         });
     }
-  };
+  }, [selectedDevice, isRecording]);
 
-  render() {
-    const {recordingEnabled} = this.state;
-    const {selectedDevice} = this.props;
-
-    return (
+  return useSandy ? (
+    <>
+      <AntButton
+        icon={<CameraOutlined />}
+        title="Take Screenshot"
+        type="ghost"
+        onClick={handleScreenshot}
+        disabled={!selectedDevice}
+        loading={isTakingScreenshot}
+      />
+      <AntButton
+        icon={<VideoCameraOutlined />}
+        title="Make Screen Recording"
+        type={isRecording ? 'primary' : 'ghost'}
+        onClick={handleRecording}
+        disabled={!selectedDevice || !isRecordingAvailable}
+        danger={isRecording}
+      />
+    </>
+  ) : (
     <ButtonGroup>
       <Button
         compact={true}
-          onClick={this.captureScreenshot}
+        onClick={handleScreenshot}
         icon="camera"
         title="Take Screenshot"
         disabled={!selectedDevice}
       />
       <Button
         compact={true}
-          onClick={this.onRecordingClicked}
-          icon={this.state.recording ? 'stop-playback' : 'camcorder'}
-          pulse={this.state.recording}
-          selected={this.state.recording}
+        onClick={handleRecording}
+        icon={isRecording ? 'stop-playback' : 'camcorder'}
+        pulse={isRecording}
+        selected={isRecording}
         title="Make Screen Recording"
-          disabled={!selectedDevice || !recordingEnabled}
+        disabled={!selectedDevice || !isRecordingAvailable}
       />
     </ButtonGroup>
   );
-  }
 }
-
-export default connect<StateFromProps, DispatchFromProps, OwnProps, Store>(
-  ({connections: {selectedDevice}}) => ({
-    selectedDevice,
-  }),
-)(ScreenCaptureButtons);

desktop/app/src/sandy-chrome/appinspect/AppInspect.tsx

@@ -11,13 +11,14 @@ import React from 'react';
 import {Alert, Button, Input} from 'antd';
 import {LeftSidebar, SidebarTitle, InfoIcon} from '../LeftSidebar';
 import {SettingOutlined, RocketOutlined} from '@ant-design/icons';
-import {Layout, Link} from '../../ui';
+import {Layout, Link, styled} from '../../ui';
 import {theme} from 'flipper-plugin';
 import {useStore as useReduxStore} from 'react-redux';
 import {showEmulatorLauncher} from './LaunchEmulator';
 import {AppSelector} from './AppSelector';
 import {useStore} from '../../utils/useStore';
 import {PluginList} from './PluginList';
+import ScreenCaptureButtons from '../../chrome/ScreenCaptureButtons';
 
 const appTooltip = (
   <>
@@ -33,6 +34,7 @@ const appTooltip = (
 export function AppInspect() {
   const store = useReduxStore();
   const selectedDevice = useStore((state) => state.connections.selectedDevice);
+
   return (
     <LeftSidebar>
       <Layout.Top>
@@ -43,18 +45,19 @@ export function AppInspect() {
           <Layout.Container padv="small" padh="medium" gap={theme.space.large}>
             <AppSelector />
             <Input addonAfter={<SettingOutlined />} defaultValue="mysite" />
-            <Layout.Horizontal gap>
-              <Button icon={<SettingOutlined />} type="link" />
-              <Button icon={<SettingOutlined />} type="link" />
+            <Toolbar gap>
+              <Button icon={<SettingOutlined />} type="ghost" />
+              <Button icon={<SettingOutlined />} type="ghost" />
               <Button
                 icon={<RocketOutlined />}
-                type="link"
+                type="ghost"
                 title="Start Emulator / Simulator..."
                 onClick={() => {
                   showEmulatorLauncher(store);
                 }}
               />
-            </Layout.Horizontal>
+              <ScreenCaptureButtons useSandy />
+            </Toolbar>
           </Layout.Container>
         </Layout.Container>
         <Layout.ScrollContainer vertical padv={theme.space.large}>
@@ -68,3 +71,9 @@ export function AppInspect() {
     </LeftSidebar>
   );
 }
+
+const Toolbar = styled(Layout.Horizontal)({
+  '.ant-btn': {
+    border: 'none',
+  },
+});