From 80fc8eb4ede37631dd210bf357f487db91f6fe3e Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Thu, 5 Oct 2023 04:37:16 -0700
Subject: [PATCH] Hide troubleshoot if a message needs to be shown

Summary: Also remove the suppress error usage as is it was never used.

Reviewed By: aigoncharov

Differential Revision: D49910876

fbshipit-source-id: 7267eaddadb73ab2b6e2aab0045157271ceed427
---
 desktop/static/index.web.dev.html | 3 +++
 desktop/static/index.web.html     | 6 ++----
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/desktop/static/index.web.dev.html b/desktop/static/index.web.dev.html
index 0414adba0..9381024a6 100644
--- a/desktop/static/index.web.dev.html
+++ b/desktop/static/index.web.dev.html
@@ -204,6 +204,9 @@
         })
 
         function showMessage(text) {
+          // Dismiss the troubleshoot as otherwise no other message is shown.
+          toggleTroubleshoot(false);
+
           if (suppressErrors) {
             return;
           }
diff --git a/desktop/static/index.web.html b/desktop/static/index.web.html
index 833f7efca..3f63b037b 100644
--- a/desktop/static/index.web.html
+++ b/desktop/static/index.web.html
@@ -144,7 +144,6 @@
       (function () {
         // FIXME: needed to make Metro work
         window.global = window;
-        let suppressErrors = false;
 
         // Listen to changes in the network state, reload when online.
         // This handles the case when the device is completely offline
@@ -167,9 +166,8 @@
         }
 
         function showMessage(text) {
-          if (suppressErrors) {
-            return;
-          }
+          // Dismiss the troubleshoot as otherwise no other message is shown.
+          toggleTroubleshoot(false);
 
           let box = document.getElementById('loading');
           if (box) {