jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make data tables horizontally scrollable if needed

Browse Source 
Summary:
Changelog: most data tables allow for horizontal scrolling now if they run out of space

This diff introduces support for horizontal scrolling in datatables. Originally thought about making this a view option, but doing automatically works actually quite fine. By default the columns resize as they did, but if either a column is made bigger or the window is so small no space is left, a horizontal scrollbar can be used.

This adresses several usability issues reported in GH / workplace

fixes https://github.com/facebook/flipper/issues/2608

Reviewed By: antonk52

Differential Revision: D33368216

fbshipit-source-id: 206c761a5873cf0396af091f2cbdedc3e638afac
This commit is contained in:
Michel Weststrate
2022-01-04 08:31:14 -08:00
committed by Facebook GitHub Bot
parent 9267a19c89
commit 80bb372920
5 changed files with 51 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
desktop/flipper-plugin/src/ui/DataList.tsx
View File

@@ -204,6 +204,7 @@ export const DataList: (<T extends object>(
enableArrow: true,
enableContextMenu: false,
enableMultiSelect: false,
enableHorizontalScroll: false,
idAttribute: 'id',
titleAttribute: 'title',
descriptionAttribute: 'description',