jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Back out "Disable Fresco integration for now (#5101)" (#5159)

Browse Source 
Summary:
Back out "Disable Fresco integration for now (https://github.com/facebook/flipper/issues/5101)"

Original commit changeset: 42b95c21eb

This is now working again with Fresco 3.1.0

 ---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/flipper/pull/5159).
* https://github.com/facebook/flipper/issues/5160
* __->__ https://github.com/facebook/flipper/issues/5159
* https://github.com/facebook/flipper/issues/5158

Pull Request resolved: https://github.com/facebook/flipper/pull/5159

Reviewed By: antonk52

Differential Revision: D49411925

Pulled By: passy

fbshipit-source-id: 34a422e60102de56fb6588e05cf4729a30e0e112
This commit is contained in:
Pascal Hartig
2023-09-19 06:16:13 -07:00
committed by Facebook GitHub Bot
parent b0f9da8ed7
commit 7f355dd19d
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java
View File

@@ -8,8 +8,10 @@
package com.facebook.flipper.sample; package com.facebook.flipper.sample;
import android.content.Intent; import android.content.Intent;
import android.net.Uri;
import com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity; import com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity;
import com.facebook.flipper.sample.network.NetworkClient; import com.facebook.flipper.sample.network.NetworkClient;
import com.facebook.fresco.vito.litho.FrescoVitoImage2;
import com.facebook.litho.ClickEvent; import com.facebook.litho.ClickEvent;
import com.facebook.litho.Column; import com.facebook.litho.Column;
import com.facebook.litho.Component; import com.facebook.litho.Component;
@@ -122,14 +124,12 @@ public class RootComponentSpec {
.marginDip(YogaEdge.ALL, 10) .marginDip(YogaEdge.ALL, 10)
.textSizeSp(20) .textSizeSp(20)
.clickHandler(RootComponent.triggerCrash(c))) .clickHandler(RootComponent.triggerCrash(c)))
// TODO: Re-enable once we have a new Litho v0.48.0-compatible version of Fresco. .child(
/*.child( FrescoVitoImage2.create(c)
FrescoVitoImage2.create(c) .uri(Uri.parse("https://fbflipper.com/img/icon.png"))
.uri(Uri.parse("https://fbflipper.com/img/icon.png")) .marginDip(YogaEdge.ALL, 10)
.marginDip(YogaEdge.ALL, 10) .widthDip(150)
.widthDip(150) .heightDip(150))
.heightDip(150))*/
.build(); .build();
return VerticalScroll.create(c).childComponent(col).build(); return VerticalScroll.create(c).childComponent(col).build();