Summary:
Back out "Disable Fresco integration for now (https://github.com/facebook/flipper/issues/5101)"
Original commit changeset: 42b95c21eb
This is now working again with Fresco 3.1.0
---
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/flipper/pull/5159).
* https://github.com/facebook/flipper/issues/5160
* __->__ https://github.com/facebook/flipper/issues/5159
* https://github.com/facebook/flipper/issues/5158
Pull Request resolved: https://github.com/facebook/flipper/pull/5159
Reviewed By: antonk52
Differential Revision: D49411925
Pulled By: passy
fbshipit-source-id: 34a422e60102de56fb6588e05cf4729a30e0e112
This commit is contained in:
committed by
Facebook GitHub Bot
parent
b0f9da8ed7
commit
7f355dd19d
@@ -8,8 +8,10 @@
|
||||
package com.facebook.flipper.sample;
|
||||
|
||||
import android.content.Intent;
|
||||
import android.net.Uri;
|
||||
import com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity;
|
||||
import com.facebook.flipper.sample.network.NetworkClient;
|
||||
import com.facebook.fresco.vito.litho.FrescoVitoImage2;
|
||||
import com.facebook.litho.ClickEvent;
|
||||
import com.facebook.litho.Column;
|
||||
import com.facebook.litho.Component;
|
||||
@@ -122,14 +124,12 @@ public class RootComponentSpec {
|
||||
.marginDip(YogaEdge.ALL, 10)
|
||||
.textSizeSp(20)
|
||||
.clickHandler(RootComponent.triggerCrash(c)))
|
||||
// TODO: Re-enable once we have a new Litho v0.48.0-compatible version of Fresco.
|
||||
/*.child(
|
||||
FrescoVitoImage2.create(c)
|
||||
.uri(Uri.parse("https://fbflipper.com/img/icon.png"))
|
||||
.marginDip(YogaEdge.ALL, 10)
|
||||
.widthDip(150)
|
||||
.heightDip(150))*/
|
||||
|
||||
.child(
|
||||
FrescoVitoImage2.create(c)
|
||||
.uri(Uri.parse("https://fbflipper.com/img/icon.png"))
|
||||
.marginDip(YogaEdge.ALL, 10)
|
||||
.widthDip(150)
|
||||
.heightDip(150))
|
||||
.build();
|
||||
|
||||
return VerticalScroll.create(c).childComponent(col).build();
|
||||
|
||||
Reference in New Issue
Block a user