From 7e9228985bad092a26a89f3ab4f8b4cc1af35f13 Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Tue, 1 Aug 2023 03:45:05 -0700
Subject: [PATCH] Show command details

Summary: This is the most basic visualiser for command details.

Reviewed By: antonk52

Differential Revision: D47917006

fbshipit-source-id: 7654a3c6e416346548b45dbc72ca4a1838bea787
---
 .../src/chrome/ConnectivityLogs.tsx           | 50 ++++++++++++++-----
 1 file changed, 37 insertions(+), 13 deletions(-)

diff --git a/desktop/flipper-ui-core/src/chrome/ConnectivityLogs.tsx b/desktop/flipper-ui-core/src/chrome/ConnectivityLogs.tsx
index bf7fd8588..b27d7ce3f 100644
--- a/desktop/flipper-ui-core/src/chrome/ConnectivityLogs.tsx
+++ b/desktop/flipper-ui-core/src/chrome/ConnectivityLogs.tsx
@@ -136,19 +136,43 @@ const Placeholder = styled(Layout.Container)({
 });
 
 function Sidebar({selection}: {selection: undefined | ConnectionRecordEntry}) {
-  return (
-    <Layout.ScrollContainer pad>
-      {selection != null ? (
-        <Panel key="Raw" heading="Raw Details">
-          <DataInspector data={selection} />
-        </Panel>
-      ) : (
-        <Placeholder grow pad="large">
-          Select an entry to visualize details
-        </Placeholder>
-      )}
-    </Layout.ScrollContainer>
-  );
+  const content: JSX.Element[] = [];
+
+  if (selection) {
+    if ('cmd' in selection) {
+      const cmd = selection as CommandRecordEntry;
+      content.push(
+        <Panel key="cmd" heading="CMD">
+          {cmd.cmd}
+        </Panel>,
+        <Panel key="description" heading="Description">
+          {cmd.description}
+        </Panel>,
+        <Panel key="stdout" heading="STDOUT">
+          {cmd.stdout}
+        </Panel>,
+        <Panel key="stderr" heading="STDERR">
+          {cmd.stderr}
+        </Panel>,
+        <Panel key="troubleshoot" heading="Troubleshooting Tips">
+          {cmd.troubleshoot}
+        </Panel>,
+      );
+    }
+    content.push(
+      <Panel key="Raw" heading="Raw Details" collapsed>
+        <DataInspector data={selection} />
+      </Panel>,
+    );
+  } else {
+    content.push(
+      <Placeholder grow pad="large" center>
+        Select an entry to visualize details
+      </Placeholder>,
+    );
+  }
+
+  return <Layout.ScrollContainer pad>{content}</Layout.ScrollContainer>;
 }
 
 function clearMessages() {