Move app/src (mostly) to flipper-ui-core/src

Summary:
This diff moves all UI code from app/src to app/flipper-ui-core. That is now slightly too much (e.g. node deps are not removed yet), but from here it should be easier to move things out again, as I don't want this diff to be open for too long to avoid too much merge conflicts.

* But at least flipper-ui-core is Electron free :)
* Killed all cross module imports as well, as they where now even more in the way
* Some unit test needed some changes, most not too big (but emotion hashes got renumbered in the snapshots, feel free to ignore that)
* Found some files that were actually meaningless (tsconfig in plugins, WatchTools files, that start generating compile errors, removed those

Follow up work:
* make flipper-ui-core configurable, and wire up flipper-server-core in Electron instead of here
* remove node deps (aigoncharov)
* figure out correct place to load GKs, plugins, make intern requests etc., and move to the correct module
* clean up deps

Reviewed By: aigoncharov

Differential Revision: D32427722

fbshipit-source-id: 14fe92e1ceb15b9dcf7bece367c8ab92df927a70
This commit is contained in:
Michel Weststrate
2021-11-16 05:25:40 -08:00
committed by Facebook GitHub Bot
parent 54b7ce9308
commit 7e50c0466a
293 changed files with 483 additions and 497 deletions

View File

@@ -9,11 +9,6 @@
import {render, fireEvent} from '@testing-library/react';
import React from 'react';
// TODO T71355623
// eslint-disable-next-line flipper/no-relative-imports-across-packages
import {Store, createRootReducer} from '../../../../app/src/reducers';
import configureStore from 'redux-mock-store';
import {Provider} from 'react-redux';
import {Value} from '../TypeBasedValueRenderer';
import DatabaseDetailSidebar from '../DatabaseDetailSidebar';
@@ -45,22 +40,9 @@ const values: Array<Value> = [
{value: 'db_1_column9_value', type: 'string'},
];
const mockStore: Store = configureStore([])(
createRootReducer()(undefined, {type: 'INIT'}),
) as Store;
beforeEach(() => {
mockStore.dispatch({type: 'rightSidebarAvailable', value: true});
mockStore.dispatch({type: 'rightSidebarVisible', value: true});
});
test('render and try to see if it renders properly', () => {
const res = render(
<Provider store={mockStore}>
<div id="detailsSidebar">
<DatabaseDetailSidebar columnLabels={labels} columnValues={values} />
</div>
</Provider>,
<DatabaseDetailSidebar columnLabels={labels} columnValues={values} />,
);
for (const label of labels) {
@@ -82,15 +64,11 @@ test('render and try to see if it renders properly', () => {
test('render edit, save, and close correctly when onSave provided', () => {
const res = render(
<Provider store={mockStore}>
<div id="detailsSidebar">
<DatabaseDetailSidebar
columnLabels={labels}
columnValues={values}
onSave={() => {}}
/>
</div>
</Provider>,
<DatabaseDetailSidebar
columnLabels={labels}
columnValues={values}
onSave={() => {}}
/>,
);
// expect only Edit to show up
@@ -120,15 +98,11 @@ test('render edit, save, and close correctly when onSave provided', () => {
test('editing some field after trigger Edit', async () => {
const mockOnSave = jest.fn((_changes) => {});
const res = render(
<Provider store={mockStore}>
<div id="detailsSidebar">
<DatabaseDetailSidebar
columnLabels={labels}
columnValues={values}
onSave={mockOnSave}
/>
</div>
</Provider>,
<DatabaseDetailSidebar
columnLabels={labels}
columnValues={values}
onSave={mockOnSave}
/>,
);
fireEvent.click(res.getByText('Edit'));