js api improvements: responnders, communication protocol
Summary: A few improvements to JS API: 1) non-dummy responders - now we can reply to flipper 2) respecting flipper communication protocol: getPlugins, getBackgroundplugins, init, deinit, execute adding linters Reviewed By: jknoxville Differential Revision: D22307525 fbshipit-source-id: 2f629210f398d118cc0cb99097c9d473bb466e57
This commit is contained in:
committed by
Facebook GitHub Bot
parent
3814c8fdfc
commit
7dbcfc89b0
90
flipper-js-client-sdk/.eslintrc.js
Normal file
90
flipper-js-client-sdk/.eslintrc.js
Normal file
@@ -0,0 +1,90 @@
|
||||
/**
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @format
|
||||
*/
|
||||
|
||||
const fbjs = require('eslint-config-fbjs');
|
||||
|
||||
// enforces copyright header and @format directive to be present in every file
|
||||
const pattern = /^\*\r?\n[\S\s]*Facebook[\S\s]* \* @format\r?\n/;
|
||||
|
||||
const prettierConfig = {
|
||||
// arrowParens=always is the default for Prettier 2.0, but other configs
|
||||
// at Facebook appear to be leaking into this file, which is still on
|
||||
// Prettier 1.x at the moment, so it is best to be explicit.
|
||||
arrowParens: 'always',
|
||||
requirePragma: true,
|
||||
singleQuote: true,
|
||||
trailingComma: 'all',
|
||||
bracketSpacing: false,
|
||||
jsxBracketSameLine: true,
|
||||
parser: 'flow',
|
||||
};
|
||||
|
||||
module.exports = {
|
||||
parser: 'babel-eslint',
|
||||
root: true,
|
||||
extends: ['fbjs', 'prettier'],
|
||||
plugins: [
|
||||
...fbjs.plugins,
|
||||
'header',
|
||||
'prettier',
|
||||
'@typescript-eslint',
|
||||
'import',
|
||||
],
|
||||
rules: {
|
||||
// disable rules from eslint-config-fbjs
|
||||
'no-new': 0, // new keyword needed e.g. new Notification
|
||||
'no-catch-shadow': 0, // only relevant for IE8 and below
|
||||
'no-bitwise': 0, // bitwise operations needed in some places
|
||||
'consistent-return': 0,
|
||||
'no-var': 2,
|
||||
'prefer-const': [2, {destructuring: 'all'}],
|
||||
'prefer-spread': 1,
|
||||
'prefer-rest-params': 1,
|
||||
'no-console': 0, // we're setting window.console in App.js
|
||||
'no-multi-spaces': 2,
|
||||
'prefer-promise-reject-errors': 1,
|
||||
'no-throw-literal': 'error',
|
||||
'no-extra-boolean-cast': 2,
|
||||
'no-extra-semi': 2,
|
||||
'no-unsafe-negation': 2,
|
||||
'no-useless-computed-key': 2,
|
||||
'no-useless-rename': 2,
|
||||
|
||||
// additional rules for this project
|
||||
'header/header': [2, 'block', {pattern}],
|
||||
'prettier/prettier': [2, prettierConfig],
|
||||
'flowtype/object-type-delimiter': [0],
|
||||
'import/no-unresolved': [2, {commonjs: true, amd: true}],
|
||||
},
|
||||
settings: {
|
||||
'import/resolver': {
|
||||
typescript: {
|
||||
extensions: ['.js', '.jsx', '.ts', '.tsx'],
|
||||
},
|
||||
},
|
||||
},
|
||||
overrides: [
|
||||
{
|
||||
files: ['*.tsx', '*.ts'],
|
||||
parser: '@typescript-eslint/parser',
|
||||
rules: {
|
||||
'prettier/prettier': [2, {...prettierConfig, parser: 'typescript'}],
|
||||
'@typescript-eslint/no-unused-vars': [
|
||||
1,
|
||||
{
|
||||
ignoreRestSiblings: true,
|
||||
varsIgnorePattern: '^_',
|
||||
argsIgnorePattern: '^_',
|
||||
caughtErrorsIgnorePattern: '^_',
|
||||
},
|
||||
],
|
||||
},
|
||||
},
|
||||
],
|
||||
};
|
||||
Reference in New Issue
Block a user