Improve framework event filtering

Summary: Now when entering framework event table from a tree root we filter that so you can see all tree events. Also we use exact matches to avoid and nasty substring bugs

Reviewed By: lblasa

Differential Revision: D48560169

fbshipit-source-id: 1df375a2b8c5035003d82c210b55adebda8bd4ec
This commit is contained in:
Luke De Feo
2023-08-23 01:51:31 -07:00
committed by Facebook GitHub Bot
parent 206ef79cf9
commit 7d9744b8ff
5 changed files with 41 additions and 17 deletions

View File

@@ -159,18 +159,20 @@ export const ContextMenu: React.FC<{
frameworkEvents.getAllRecordsByIndex({nodeId: hoveredNode.id})) ??
[];
const frameworkEventsTable = matchingFrameworkEvents.length > 0 && (
<UIDebuggerMenuItem
text="Explore events"
onClick={() => {
onSetViewMode({
mode: 'frameworkEventsTable',
nodeId: hoveredNode?.id ?? '',
});
}}
icon={<TableOutlined />}
/>
);
const frameworkEventsTable = matchingFrameworkEvents.length > 0 &&
hoveredNode && (
<UIDebuggerMenuItem
text="Explore events"
onClick={() => {
onSetViewMode({
mode: 'frameworkEventsTable',
nodeId: hoveredNode.id,
isTree: hoveredNode.tags.includes('TreeRoot'),
});
}}
icon={<TableOutlined />}
/>
);
return (
<Dropdown