jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve errors around screen capture

Browse Source 
Summary:
Tasks like T143443148 pop up frequently and are inactionable. This is usually due to device flakiness, storage being full, incompatibility or configuration problems.

Start and stop were also copy-pasted to make matters worse.

Reviewed By: ivanmisuno

Differential Revision: D42800489

fbshipit-source-id: 11caaa4133e4fa1d773364a6ba4e5f5bb0d2f2ce
This commit is contained in:
Pascal Hartig
2023-01-30 03:18:19 -08:00
committed by Facebook GitHub Bot
parent 9540ea579c
commit 7d58037ad6
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/flipper-ui-core/src/chrome/ScreenCaptureButtons.tsx
View File

@@ -45,7 +45,7 @@ export default function ScreenCaptureButtons() {
setIsRecording(true); setIsRecording(true);
const videoPath = path.join(getCaptureLocation(), getFileName('mp4')); const videoPath = path.join(getCaptureLocation(), getFileName('mp4'));
return selectedDevice.startScreenCapture(videoPath).catch((e) => { return selectedDevice.startScreenCapture(videoPath).catch((e) => {
console.error('Failed to start recording', e); console.warn('Failed to start recording', e);
message.error('Failed to start recording' + e); message.error('Failed to start recording' + e);
setIsRecording(false); setIsRecording(false);
}); });
@@ -58,8 +58,8 @@ export default function ScreenCaptureButtons() {
} }
}) })
.catch((e) => { .catch((e) => {
console.error('Failed to start recording', e); console.warn('Failed to stop recording', e);
message.error('Failed to start recording' + e); message.error('Failed to stop recording' + e);
}) })
.finally(() => { .finally(() => {
setIsRecording(false); setIsRecording(false);