Stop storing device logs on the device object and in the plugin

Summary:
Logs were stored hardcoded on the Device object first, this diff makes it normal plugin state.

This makes sure that we can use the same abstractions as in all plugins that store large data sets, and that we can leverage the upcoming DataSource abstraction.

Reviewed By: nikoant

Differential Revision: D26127243

fbshipit-source-id: 7c386a615fa7989f35ba0df5b7c1d218d37b57a2

desktop/flipper-plugin/src/plugin/PluginBase.tsx

@@ -17,11 +17,11 @@ import {batched} from '../state/batch';
 import {Idler} from '../utils/Idler';
 import {message} from 'antd';
 
-type StateExportHandler = (
+type StateExportHandler<T = any> = (
   idler: Idler,
   onStatusMessage: (msg: string) => void,
-) => Promise<Record<string, any>>;
-type StateImportHandler = (data: Record<string, any>) => void;
+) => Promise<T>;
+type StateImportHandler<T = any> = (data: T) => void;
 
 export interface BasePluginClient {
   readonly device: Device;
@@ -50,13 +50,13 @@ export interface BasePluginClient {
    * Triggered when the current plugin is being exported and should create a snapshot of the state exported.
    * Overrides the default export behavior and ignores any 'persist' flags of state.
    */
-  onExport(exporter: StateExportHandler): void;
+  onExport<T = any>(exporter: StateExportHandler<T>): void;
 
   /**
    * Triggered directly after the plugin instance was created, if the plugin is being restored from a snapshot.
    * Should be the inverse of the onExport handler
    */
-  onImport(handler: StateImportHandler): void;
+  onImport<T = any>(handler: StateImportHandler<T>): void;
 
   /**
    * Register menu entries in the Flipper toolbar
@@ -163,7 +163,7 @@ export abstract class BasePluginInstance {
       if (this.initialStates) {
         if (this.importHandler) {
           try {
-            this.importHandler(this.initialStates);
+            batched(this.importHandler)(this.initialStates);
           } catch (e) {
             const msg = `Error occurred when importing date for plugin '${this.definition.id}': '${e}`;
             console.error(msg, e);