Stop storing device logs on the device object and in the plugin
Summary: Logs were stored hardcoded on the Device object first, this diff makes it normal plugin state. This makes sure that we can use the same abstractions as in all plugins that store large data sets, and that we can leverage the upcoming DataSource abstraction. Reviewed By: nikoant Differential Revision: D26127243 fbshipit-source-id: 7c386a615fa7989f35ba0df5b7c1d218d37b57a2
This commit is contained in:
committed by
Facebook GitHub Bot
parent
f2ade40239
commit
7cc55daf34
@@ -86,7 +86,6 @@ export default class AndroidDevice extends BaseDevice {
|
||||
}
|
||||
|
||||
clearLogs(): Promise<void> {
|
||||
this.logEntries = [];
|
||||
return this.executeShell(['logcat', '-c']);
|
||||
}
|
||||
|
||||
@@ -96,7 +95,6 @@ export default class AndroidDevice extends BaseDevice {
|
||||
deviceType: this.deviceType,
|
||||
title: this.title,
|
||||
os: this.os,
|
||||
logEntries: [...this.logEntries],
|
||||
screenshotHandle: null,
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user