From 7ba57dae336f1d82adf4216395073d0b8f82cfa6 Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Fri, 24 Apr 2020 10:42:31 -0700 Subject: [PATCH] Expose flipper as peer-, not full dependency Summary: Flipper should never be a normal dependency of a flipper plugin. And since this an example, lets do it properly :) Reviewed By: jknoxville, passy Differential Revision: D21228427 fbshipit-source-id: 72166c8706a213e2cb649f1201984dd722b63d2f --- desktop/plugins/seamammals/package.json | 3 ++- docs/tutorial/js-setup.md | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/desktop/plugins/seamammals/package.json b/desktop/plugins/seamammals/package.json index fa04cf751..edb575fe7 100644 --- a/desktop/plugins/seamammals/package.json +++ b/desktop/plugins/seamammals/package.json @@ -19,10 +19,11 @@ "scripts": { "prepack": "flipper-pkg bundle" }, - "dependencies": { + "peerDependencies": { "flipper": "0.39.0" }, "devDependencies": { + "flipper": "0.39.0", "flipper-pkg": "0.39.0" } } diff --git a/docs/tutorial/js-setup.md b/docs/tutorial/js-setup.md index ddc9887f2..88284ec9c 100644 --- a/docs/tutorial/js-setup.md +++ b/docs/tutorial/js-setup.md @@ -66,10 +66,11 @@ For instance: "scripts": { "prepack": "flipper-pkg bundle" }, - "dependencies": { + "peerDependencies": { "flipper": "latest" }, "devDependencies": { + "flipper": "latest", "flipper-pkg": "latest" } }