jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix code formatting

Browse Source 
Summary:
Had some horrible dev experience caused by  VSCode and Jest not agreeing what snapshots should look like, every time saving a test in VSCode, it would break the jest snapshots. After investigating eslint and prettier, turned out VSCode itself was the culprit. Caused by a global user setting, but this makes sure nobody else runs into it :)

Also made sure Jest uses the correct prettier settings (it didn't before).

Reviewed By: passy

Differential Revision: D22114656

fbshipit-source-id: aef6c278a668bce049c96aba95c7a5101ca840ad
This commit is contained in:
Michel Weststrate
2020-06-19 03:53:20 -07:00
committed by Facebook GitHub Bot
parent cf9309b039
commit 7b69b96190
3 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.vscode/settings.json vendored
View File

@@ -5,6 +5,7 @@
"eslint.packageManager": "yarn",
"eslint.codeActionsOnSave.mode": "all",
"editor.formatOnSave": true,
"files.trimTrailingWhitespace": false, // This one is broken as it cleans string literals as well, killing Jest snapshots: https://github.com/Microsoft/vscode/issues/52711
"prettier.formatAlreadyFormattedFilesOnSave": false,
"files.eol": "\n",
"editor.codeActionsOnSave": {