jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove getBaseContext

Browse Source 
Summary:
We have getAndroidContext() instead.

This will probably take a few iterations to land, but getting it out there so that I can try :)

Reviewed By: muraziz

Differential Revision: D12921523

fbshipit-source-id: 038ecf8c411fdbde6831051b219a43716007ac49
This commit is contained in:
Ian Childs
2018-11-07 04:17:55 -08:00
committed by Facebook Github Bot
parent db42e8e970
commit 7b569a1692
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java
View File

@@ -135,8 +135,8 @@ public class RootComponentSpec {
@OnEvent(ClickEvent.class) @OnEvent(ClickEvent.class)
static void openDiagnostics(final ComponentContext c) { static void openDiagnostics(final ComponentContext c) {
Intent intent = new Intent(c.getBaseContext(), FlipperDiagnosticActivity.class); Intent intent = new Intent(c.getAndroidContext(), FlipperDiagnosticActivity.class);
c.getBaseContext().startActivity(intent); c.getAndroidContext().startActivity(intent);
} }
} }

4
android/src/main/java/com/facebook/flipper/plugins/litho/DebugComponentDescriptor.java
View File

@@ -622,9 +622,9 @@ public class DebugComponentDescriptor extends NodeDescriptor<DebugComponent> {
return fromDrawable(null); return fromDrawable(null);
} }
final T d = Reference.acquire(c.getBaseContext(), r); final T d = Reference.acquire(c.getAndroidContext(), r);
final InspectorValue v = fromDrawable(d); final InspectorValue v = fromDrawable(d);
Reference.release(c.getBaseContext(), d, r); Reference.release(c.getAndroidContext(), d, r);
return v; return v;
} }