Fix Android device connection for Kitkat
Summary: Probably more than just KitKat, but we got a specific report in https://fburl.com/f88cvz4c for 4.4. ABI lists are not included in the probs and unfortunately TS doesn't resolve this to a `string | undefined` as it should. {F336605489} Reviewed By: jknoxville Differential Revision: D23815568 fbshipit-source-id: b6af928f85549d0c973feb0d83a324252ce0f654
This commit is contained in:
committed by
Facebook GitHub Bot
parent
6c377ade5c
commit
7aaf5585a2
@@ -38,8 +38,8 @@ function createDevice(
|
||||
.then(async (props) => {
|
||||
try {
|
||||
let name = props['ro.product.model'];
|
||||
const abiString = props['ro.product.cpu.abilist'];
|
||||
const sdkVersion = props['ro.build.version.sdk'];
|
||||
const abiString = props['ro.product.cpu.abilist'] || '';
|
||||
const sdkVersion = props['ro.build.version.sdk'] || '';
|
||||
const abiList = abiString.length > 0 ? abiString.split(',') : [];
|
||||
if (type === 'emulator') {
|
||||
name = (await getRunningEmulatorName(device.id)) || name;
|
||||
|
||||
Reference in New Issue
Block a user