jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Migrate Flipper samples to use Fresco Vito (#4861)

Browse Source 
Summary: Pull Request resolved: https://github.com/facebook/flipper/pull/4861

Reviewed By: steelrooter

Differential Revision: D46149846

fbshipit-source-id: 3b2a89da2a4e5ea2ee325e035e793ee18c5ce86d
This commit is contained in:
Alexander Oprisnik
2023-06-27 09:28:59 -07:00
committed by Facebook GitHub Bot
parent 44925c687e
commit 79e3abf6eb
7 changed files with 24 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
android/sample/build.gradle
View File

@@ -87,6 +87,9 @@ dependencies {
implementation deps.soloader
implementation deps.okhttp3
implementation deps.fresco
implementation deps.frescoUiCommon
implementation deps.frescoVito
implementation deps.frescoVitoLitho
debugImplementation deps.flipperFrescoPlugin
// Integration test

2
android/sample/src/main/java/com/facebook/flipper/sample/FlipperSampleApplication.java
View File

@@ -14,6 +14,7 @@ import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.flipper.android.AndroidFlipperClient;
import com.facebook.flipper.core.FlipperClient;
import com.facebook.flipper.sample.network.NetworkClient;
import com.facebook.fresco.vito.init.FrescoVito;
import com.facebook.soloader.SoLoader;
public class FlipperSampleApplication extends Application {
@@ -22,6 +23,7 @@ public class FlipperSampleApplication extends Application {
super.onCreate();
SoLoader.init(this, false);
Fresco.initialize(this);
FrescoVito.initialize();
final FlipperClient client = AndroidFlipperClient.getInstance(this);
assert client != null;

12
android/sample/src/main/java/com/facebook/flipper/sample/RootComponentSpec.java
View File

@@ -8,10 +8,10 @@
package com.facebook.flipper.sample;
import android.content.Intent;
import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.drawee.interfaces.DraweeController;
import android.net.Uri;
import com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity;
import com.facebook.flipper.sample.network.NetworkClient;
import com.facebook.fresco.vito.litho.FrescoVitoImage2;
import com.facebook.litho.ClickEvent;
import com.facebook.litho.Column;
import com.facebook.litho.Component;
@@ -22,7 +22,6 @@ import com.facebook.litho.annotations.OnCreateLayout;
import com.facebook.litho.annotations.OnEvent;
import com.facebook.litho.annotations.OnUpdateState;
import com.facebook.litho.annotations.State;
import com.facebook.litho.fresco.FrescoImage;
import com.facebook.litho.widget.Text;
import com.facebook.litho.widget.VerticalScroll;
import com.facebook.yoga.YogaEdge;
@@ -32,9 +31,6 @@ public class RootComponentSpec {
@OnCreateLayout
static Component onCreateLayout(final ComponentContext c, @State boolean displayImage) {
final DraweeController controller =
Fresco.newDraweeControllerBuilder().setUri("https://fbflipper.com/img/icon.png").build();
Column col =
Column.create(c)
.child(
@@ -129,8 +125,8 @@ public class RootComponentSpec {
.textSizeSp(20)
.clickHandler(RootComponent.triggerCrash(c)))
.child(
FrescoImage.create(c)
.controller(controller)
FrescoVitoImage2.create(c)
.uri(Uri.parse("https://fbflipper.com/img/icon.png"))
.marginDip(YogaEdge.ALL, 10)
.widthDip(150)
.heightDip(150))