jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace ITSR GK with a new one

Browse Source 
Summary:
Michel discovered that the ITSR GK has been dialled down completely since the last bug.

Coming to re-enable it I discovered a bug that has been introduced since then, so have fixed that, but we can't just ramp up the original GK because the current version of flipper will crash if ITSR is used.

So instead, I'm leaving the current GK ramped down, and replacing it with a new one, which is safe to ramp up.

This will mean ITSR is only enabled on versions from the next release onwards.

Reviewed By: nikoant

Differential Revision: D24922822

fbshipit-source-id: 8a6990fd5130bd046c24b0da757492b37e4040f2
This commit is contained in:
John Knox
2020-11-13 01:19:33 -08:00
committed by Facebook GitHub Bot
parent dcdec2608e
commit 797fd0517f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/app/src/chrome/RatingButton.tsx
View File

@@ -308,7 +308,7 @@ class RatingButton extends Component<PropsFromState, State> {
constructor(props: PropsFromState) { constructor(props: PropsFromState) {
super(props); super(props);
if (GK.get('flipper_rating')) { if (GK.get('flipper_enable_star_ratiings')) {
UserFeedback.getPrompt().then((prompt) => { UserFeedback.getPrompt().then((prompt) => {
this.setState({promptData: prompt}); this.setState({promptData: prompt});
setTimeout(this.triggerPopover.bind(this), 30000); setTimeout(this.triggerPopover.bind(this), 30000);