From 77bc432a81c1b1b732980c8fd72e199b01499a11 Mon Sep 17 00:00:00 2001 From: John Knox Date: Tue, 16 Jun 2020 08:13:20 -0700 Subject: [PATCH] Don't filter iOS devices by name Summary: Well this is embarassing. My iPhone is called iPhone, so I assumed instruments always outputs "iPhone" for iPhones, but it doesn't if they've got a different name. Pointed out in https://github.com/facebook/flipper/issues/262 Reviewed By: nikoant Differential Revision: D22066872 fbshipit-source-id: 847e1baf28103692dc9472d9730b6384ec719be0 --- desktop/app/src/utils/iOSContainerUtility.tsx | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/desktop/app/src/utils/iOSContainerUtility.tsx b/desktop/app/src/utils/iOSContainerUtility.tsx index 0ecd983b8..51f289e81 100644 --- a/desktop/app/src/utils/iOSContainerUtility.tsx +++ b/desktop/app/src/utils/iOSContainerUtility.tsx @@ -56,10 +56,7 @@ async function targets(): Promise> { .map((line) => line.trim()) .map((line) => /(.+) \([^(]+\) \[(.*)\]( \(Simulator\))?/.exec(line)) .filter(notNull) - .filter( - ([_match, name, _udid, isSim]) => - !isSim && (name.includes('iPhone') || name.includes('iPad')), - ) + .filter(([_match, _name, _udid, isSim]) => !isSim) .map(([_match, name, udid]) => { return {udid: udid, type: 'physical', name: name}; }),