jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Overdue refactor for TroubleshootingHub

Browse Source 
Summary: It's troubleshooting in general, not only connectivity. So rename and refactor accordingly.

Reviewed By: antonk52

Differential Revision: D47914411

fbshipit-source-id: 658563bfd33427f11fe9f7660b0985fc3f013866
This commit is contained in:
Lorenzo Blasa
2023-07-31 07:02:16 -07:00
committed by Facebook GitHub Bot
parent d83f3fddb2
commit 778eaf2038
4 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
desktop/flipper-ui-core/src/chrome/ConnectivityHub.tsx → desktop/flipper-ui-core/src/chrome/TroubleshootingHub.tsx
View File

@@ -36,7 +36,7 @@ const rows = createDataSource<ConnectionRecordEntry>([], {
persist: 'connectivity-logs', persist: 'connectivity-logs',
}); });
export function enableConnectivityHub(flipperServer: FlipperServer) { export function enableConnectivityHook(flipperServer: FlipperServer) {
flipperServer.on( flipperServer.on(
'connectivity-troubleshoot-log', 'connectivity-troubleshoot-log',
(entry: ConnectionRecordEntry) => { (entry: ConnectionRecordEntry) => {
@@ -189,7 +189,7 @@ const LogView = () => {
); );
}; };
export function ConnectivityHub() { export function TroubleshootingHub() {
return ( return (
<Layout.Container grow> <Layout.Container grow>
<Tabs activeKey="connectivity-logs" grow> <Tabs activeKey="connectivity-logs" grow>

4
desktop/flipper-ui-core/src/dispatcher/flipperServer.tsx
View File

@@ -27,7 +27,7 @@ import {waitFor} from '../utils/waitFor';
import {NotificationBody} from '../ui/components/NotificationBody'; import {NotificationBody} from '../ui/components/NotificationBody';
import {Layout} from '../ui'; import {Layout} from '../ui';
import {setStaticView} from '../reducers/connections'; import {setStaticView} from '../reducers/connections';
import {ConnectivityHub} from '../chrome/ConnectivityHub'; import {TroubleshootingHub} from '../chrome/TroubleshootingHub';
import {setTopLevelSelection} from '../reducers/application'; import {setTopLevelSelection} from '../reducers/application';
export function connectFlipperServerToStore( export function connectFlipperServerToStore(
@@ -315,7 +315,7 @@ function showConnectivityTroubleshootNotification(
style={{float: 'right'}} style={{float: 'right'}}
onClick={() => { onClick={() => {
store.dispatch(setTopLevelSelection('connectivity')); store.dispatch(setTopLevelSelection('connectivity'));
store.dispatch(setStaticView(ConnectivityHub)); store.dispatch(setStaticView(TroubleshootingHub));
notification.close(key); notification.close(key);
}}> }}>
Troubleshoot Troubleshoot

4
desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx
View File

@@ -71,7 +71,7 @@ import {
import {StatusMessage} from './appinspect/AppInspect'; import {StatusMessage} from './appinspect/AppInspect';
import {TroubleshootingGuide} from './appinspect/fb-stubs/TroubleshootingGuide'; import {TroubleshootingGuide} from './appinspect/fb-stubs/TroubleshootingGuide';
import {FlipperDevTools} from '../chrome/FlipperDevTools'; import {FlipperDevTools} from '../chrome/FlipperDevTools';
import {ConnectivityHub} from '../chrome/ConnectivityHub'; import {TroubleshootingHub} from '../chrome/TroubleshootingHub';
export const Navbar = withTrackingScope(function Navbar() { export const Navbar = withTrackingScope(function Navbar() {
const {topLevelSelection, selectedDevice, selectedAppId, selectedPlugin} = const {topLevelSelection, selectedDevice, selectedAppId, selectedPlugin} =
@@ -516,7 +516,7 @@ function TroubleshootMenu() {
key="connectivity" key="connectivity"
onClick={() => { onClick={() => {
store.dispatch(setTopLevelSelection('connectivity')); store.dispatch(setTopLevelSelection('connectivity'));
store.dispatch(setStaticView(ConnectivityHub)); store.dispatch(setStaticView(TroubleshootingHub));
}}> }}>
Troubleshoot Connectivity Troubleshoot Connectivity
</Menu.Item> </Menu.Item>

4
desktop/flipper-ui-core/src/startFlipperDesktop.tsx
View File

@@ -43,7 +43,7 @@ import {getRenderHostInstance} from 'flipper-frontend-core';
import {startGlobalErrorHandling} from './utils/globalErrorHandling'; import {startGlobalErrorHandling} from './utils/globalErrorHandling';
import {loadTheme} from './utils/loadTheme'; import {loadTheme} from './utils/loadTheme';
import {connectFlipperServerToStore} from './dispatcher/flipperServer'; import {connectFlipperServerToStore} from './dispatcher/flipperServer';
import {enableConnectivityHub} from './chrome/ConnectivityHub'; import {enableConnectivityHook} from './chrome/TroubleshootingHub';
import ReactDOM from 'react-dom'; import ReactDOM from 'react-dom';
class AppFrame extends React.Component< class AppFrame extends React.Component<
@@ -178,7 +178,7 @@ function init(flipperServer: FlipperServer) {
); );
enableConsoleHook(); enableConsoleHook();
enableConnectivityHub(flipperServer); enableConnectivityHook(flipperServer);
const launcherMessage = const launcherMessage =
getRenderHostInstance().serverConfig.processConfig.launcherMsg; getRenderHostInstance().serverConfig.processConfig.launcherMsg;