Use yargs for non-headless Flipper args parsing

Summary:
This seems like a better approach than ad-hoc lookup in
`electron.remove.argv`. Left a note to a task to provide
a better interface to this.

I also need this in order to ensure we're starting
Flipper through the launcher which needs to happen
before we start the Electron runtime.

Reviewed By: jknoxville

Differential Revision: D13881355

fbshipit-source-id: 69c70d71035a47084f789ddb4dc969b45ba4648b

src/utils/argvUtils.js

@@ -9,7 +9,9 @@ import electron from 'electron';
 import isProduction from './isProduction';
 
 export const isAutoUpdaterEnabled = () =>
-  // $FlowFixMe: argv is not included in the type defs.
-  !electron.remote.process.argv.includes('--no-updater') &&
+  // TODO(T39788540): Centralise config access and avoid parsing multiple times.
+  // $FlowFixMe: env is not in the type defs.
+  JSON.parse(electron.remote?.process.env.CONFIG || process.env.CONFIG || '{}')
+    .updaterEnabled &&
   isProduction() &&
-  process.platform === 'darwin';
+  process.platform === 'darwin';