Pass plugins via ipc instead of env to fix loading of plugins on Windows

Summary: Fixed the issue with empty plugin list on Windows because of env var length limit

Reviewed By: passy

Differential Revision: D19411466

fbshipit-source-id: 7fa390f7dd342e23e965b2135fbeb8e88e5857ef

__mocks__/electron.tsx

@@ -20,4 +20,5 @@ module.exports = {
     },
     getCurrentWindow: () => ({isFocused: () => true}),
   },
+  ipcRenderer: {},
 };

src/dispatcher/__tests__/plugins.node.js

@@ -14,7 +14,7 @@ import dispatcher, {
   requirePlugin,
 } from '../plugins.tsx';
 import path from 'path';
-import {remote} from 'electron';
+import {ipcRenderer, remote} from 'electron';
 import {FlipperPlugin} from 'flipper';
 import reducers from '../../reducers/index.tsx';
 import {init as initLogger} from '../../fb-stubs/Logger.tsx';
@@ -31,24 +31,20 @@ test('dispatcher dispatches REGISTER_PLUGINS', () => {
   expect(actions.map(a => a.type)).toContain('REGISTER_PLUGINS');
 });
 
-test('getDynamicPlugins returns empty array', () => {
+test('getDynamicPlugins returns empty array on errors', () => {
-  // $FlowFixMe process.env not defined in electron API spec
+  ipcRenderer.sendSync = jest.fn();
-  remote.process.env.PLUGINS = null;
+  ipcRenderer.sendSync.mockImplementation(() => {
+    console.log('aaa');
+    throw new Error('ooops');
+  });
   const res = getDynamicPlugins();
   expect(res).toEqual([]);
 });
 
-test('getDynamicPlugins returns empty array for invalid JSON', () => {
+test('getDynamicPlugins from main process via ipc', () => {
-  // $FlowFixMe process.env not defined in electron API spec
-  remote.process.env.PLUGINS = 'invalid JOSN }}[]';
-  const res = getDynamicPlugins();
-  expect(res).toEqual([]);
-});
-
-test('getDynamicPlugins from env', () => {
   const plugins = [{name: 'test'}];
-  // $FlowFixMe process.env not defined in electron API spec
+  ipcRenderer.sendSync = jest.fn();
-  remote.process.env.PLUGINS = JSON.stringify(plugins);
+  ipcRenderer.sendSync.mockReturnValue(plugins);
   const res = getDynamicPlugins();
   expect(res).toEqual(plugins);
 });

src/dispatcher/plugins.tsx

@@ -21,7 +21,7 @@ import {
   addDisabledPlugins,
   addFailedPlugins,
 } from '../reducers/plugins';
-import {remote} from 'electron';
+import {ipcRenderer} from 'electron';
 import GK from '../fb-stubs/GK';
 import {FlipperBasePlugin} from '../plugin';
 import {setupMenuBar} from '../MenuBar';
@@ -110,9 +110,7 @@ function getBundledPlugins(): Array<PluginDefinition> {
 export function getDynamicPlugins() {
   let dynamicPlugins: Array<PluginDefinition> = [];
   try {
-    dynamicPlugins = JSON.parse(
+    dynamicPlugins = ipcRenderer.sendSync('get-dynamic-plugins');
-      (remote && remote.process.env.PLUGINS) || process.env.PLUGINS || '[]',
-    );
   } catch (e) {
     console.error(e);
   }

static/index.js

@@ -111,7 +111,9 @@ compilePlugins(
   pluginPaths,
   path.join(flipperDir, 'plugins'),
 ).then(dynamicPlugins => {
-  process.env.PLUGINS = JSON.stringify(dynamicPlugins);
+  ipcMain.on('get-dynamic-plugins', event => {
+    event.returnValue = dynamicPlugins;
+  });
   pluginsCompiled = true;
   tryCreateWindow();
 });