Move troubleshooting guide into a menu

Reviewed By: lblasa

Differential Revision: D47591882

fbshipit-source-id: 84e3732100aa20d5f78b132a4c429b9b742678e9

desktop/flipper-ui-core/src/sandy-chrome/Navbar.tsx

@@ -70,6 +70,7 @@ import {
   NavbarScreenshotButton,
 } from '../chrome/ScreenCaptureButtons';
 import {StatusMessage} from './appinspect/AppInspect';
+import {TroubleshootingGuide} from './appinspect/fb-stubs/TroubleshootingGuide';
 
 export const Navbar = withTrackingScope(function Navbar({
   toplevelSelection,
@@ -509,6 +510,7 @@ function TroubleshootMenu({
                 Troubleshoot connectivity
               </Menu.Item>
             )}
+            <TroubleshootingGuide />
             <Menu.Item
               key="flipperlogs"
               onClick={() => setToplevelSelection('flipperlogs')}>

desktop/flipper-ui-core/src/sandy-chrome/appinspect/AppSelector.tsx

@@ -29,7 +29,6 @@ import {BaseDevice} from 'flipper-frontend-core';
 import Client from '../../Client';
 import {State} from '../../reducers';
 import {brandColors, brandIcons, colors} from '../../ui/components/colors';
-import {TroubleshootingGuide} from './fb-stubs/TroubleshootingGuide';
 import {getSelectableDevices} from '../../selectors/connections';
 import {getRenderHostInstance} from 'flipper-frontend-core';
 import {NoDevices} from './NoDevices';
@@ -139,11 +138,7 @@ export function AppSelector() {
       )}
       {
         /* Return the public component NoDevices if showGuide is false (This means that the user is not in the GK Allowlist) and no devices are detected */
-        !gkSelfSufficiency && entries.length == 0 ? (
-          <NoDevices />
-        ) : !gkSelfSufficiency && entries.length > 0 ? null : (
-          <TroubleshootingGuide />
-        )
+        !gkSelfSufficiency && entries.length == 0 ? <NoDevices /> : null
       }
     </>
   );