jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rename FlipperCppWrapperPlugin

Browse Source 
Summary: Renames FlipperCppWrapperPlugin

Reviewed By: passy

Differential Revision: D10028505

fbshipit-source-id: d4245a49e2c8cbc8d06ed17c93ee5cb28ce49838
This commit is contained in:
Pritesh Nandgaonkar
2018-09-25 13:27:34 -07:00
committed by Facebook Github Bot
parent e6aeb24fcc
commit 706ef2a1c8
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
iOS/FlipperKit/CppBridge/SonarCppWrapperPlugin.h → iOS/FlipperKit/CppBridge/FlipperCppWrapperPlugin.h
View File

@@ -23,10 +23,10 @@ SonarCppWrapperPlugin is a simple C++ wrapper around Objective-C Sonar plugins
that can be passed to SonarClient. This class allows developers to write pure that can be passed to SonarClient. This class allows developers to write pure
Objective-C plugins if they want. Objective-C plugins if they want.
*/ */
class SonarCppWrapperPlugin final : public facebook::flipper::FlipperPlugin { class FlipperCppWrapperPlugin final : public facebook::flipper::FlipperPlugin {
public: public:
// Under ARC copying objCPlugin *does* increment its retain count // Under ARC copying objCPlugin *does* increment its retain count
SonarCppWrapperPlugin(ObjCPlugin objCPlugin) : _objCPlugin(objCPlugin) {} FlipperCppWrapperPlugin(ObjCPlugin objCPlugin) : _objCPlugin(objCPlugin) {}
std::string identifier() const override { return [[_objCPlugin identifier] UTF8String]; } std::string identifier() const override { return [[_objCPlugin identifier] UTF8String]; }

4
iOS/FlipperKit/FlipperClient.mm
View File

@@ -8,7 +8,7 @@
#if FB_SONARKIT_ENABLED #if FB_SONARKIT_ENABLED
#import "FlipperClient.h" #import "FlipperClient.h"
#import "SonarCppWrapperPlugin.h" #import "FlipperCppWrapperPlugin.h"
#import <Flipper/FlipperClient.h> #import <Flipper/FlipperClient.h>
#include <folly/io/async/EventBase.h> #include <folly/io/async/EventBase.h>
#include <folly/io/async/ScopedEventBaseThread.h> #include <folly/io/async/ScopedEventBaseThread.h>
@@ -20,7 +20,7 @@
//#import "SKPortForwardingServer.h" //#import "SKPortForwardingServer.h"
#endif #endif
using WrapperPlugin = facebook::flipper::SonarCppWrapperPlugin; using WrapperPlugin = facebook::flipper::FlipperCppWrapperPlugin;
@implementation FlipperClient { @implementation FlipperClient {
facebook::flipper::FlipperClient *_cppClient; facebook::flipper::FlipperClient *_cppClient;

6
iOS/FlipperKitTests/FlipperCppBridgingTests.mm
View File

@@ -9,10 +9,10 @@
#if FB_SONARKIT_ENABLED #if FB_SONARKIT_ENABLED
#import <FlipperKit/CppBridge/SonarCppWrapperPlugin.h> #import <FlipperKit/CppBridge/FlipperCppWrapperPlugin.h>
#import <FlipperKit/FlipperPlugin.h> #import <FlipperKit/FlipperPlugin.h>
using facebook::flipper::SonarCppWrapperPlugin; using facebook::flipper::FlipperCppWrapperPlugin;
@interface DummyPlugin : NSObject <FlipperPlugin> @interface DummyPlugin : NSObject <FlipperPlugin>
@end @end
@@ -31,7 +31,7 @@ using facebook::flipper::SonarCppWrapperPlugin;
- (void)testCppWrapperRetainsObjCPlugin { - (void)testCppWrapperRetainsObjCPlugin {
NSObject<FlipperPlugin> *dummyPlugin = [DummyPlugin new]; NSObject<FlipperPlugin> *dummyPlugin = [DummyPlugin new];
auto retainCountBefore = CFGetRetainCount((void *)dummyPlugin); auto retainCountBefore = CFGetRetainCount((void *)dummyPlugin);
SonarCppWrapperPlugin wrapperPlugin(dummyPlugin); FlipperCppWrapperPlugin wrapperPlugin(dummyPlugin);
auto retainCountAfter = CFGetRetainCount((void *)dummyPlugin); auto retainCountAfter = CFGetRetainCount((void *)dummyPlugin);
XCTAssertTrue(retainCountAfter > retainCountBefore); XCTAssertTrue(retainCountAfter > retainCountBefore);
} }