read infos from package.json
Summary: Adding the properties from a plugin's `package.json` as static properties to the class. The name from `package.json` is used as it's `id`. This allows us in the future to add meta information about a plugin to it's package.json and still use the data inside the app. Reviewed By: priteshrnandgaonkar Differential Revision: D13417288 fbshipit-source-id: 3d0a62d4cb0115153cce1aaee677b9680fefebf4
This commit is contained in:
committed by
Facebook Github Bot
parent
e23da69db9
commit
6ffc027051
@@ -146,11 +146,11 @@ class PluginSidebarListItem extends Component<{
|
||||
<ListItem active={isActive} onClick={this.props.onClick}>
|
||||
<PluginIcon
|
||||
isActive={isActive}
|
||||
name={plugin.icon}
|
||||
name={plugin.icon || 'apps'}
|
||||
backgroundColor={iconColor}
|
||||
color={colors.white}
|
||||
/>
|
||||
<PluginName>{plugin.title}</PluginName>
|
||||
<PluginName>{plugin.title || plugin.id}</PluginName>
|
||||
</ListItem>
|
||||
);
|
||||
}
|
||||
@@ -228,7 +228,11 @@ class MainSidebar extends PureComponent<MainSidebarProps> {
|
||||
}>
|
||||
<PluginIcon
|
||||
color={colors.light50}
|
||||
name={numNotifications > 0 ? NotificationsHub.icon : 'bell-null'}
|
||||
name={
|
||||
numNotifications > 0
|
||||
? NotificationsHub.icon || 'bell'
|
||||
: 'bell-null'
|
||||
}
|
||||
isActive={selectedPlugin === NotificationsHub.id}
|
||||
/>
|
||||
<PluginName
|
||||
|
||||
Reference in New Issue
Block a user