From 6eb1531aaef0d1f31a5bb7c311bc4ae19f68ebe1 Mon Sep 17 00:00:00 2001 From: John Knox Date: Wed, 4 Sep 2019 04:02:49 -0700 Subject: [PATCH] Remove rsocket payload size assertion Summary: Don't fatal when trying to send a message to flipper that is too large. Instead just continue to throw an exception, so the plugin will still be aware of the failure. Reviewed By: cpojer, danielbuechele Differential Revision: D17180334 fbshipit-source-id: 49c341a7cee579158be3878639083c6d19b3eaa3 --- xplat/Flipper/FlipperConnectionManagerImpl.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/xplat/Flipper/FlipperConnectionManagerImpl.cpp b/xplat/Flipper/FlipperConnectionManagerImpl.cpp index 33a8a8f1b..12bcabac0 100644 --- a/xplat/Flipper/FlipperConnectionManagerImpl.cpp +++ b/xplat/Flipper/FlipperConnectionManagerImpl.cpp @@ -356,7 +356,6 @@ rsocket::Payload toRSocketPayload(dynamic data) { "Error: Skipping sending message larger than max rsocket payload: ") + json.substr(0, 100) + "..."; log(logMessage); - DCHECK_LE(payloadLength, maxPayloadSize); throw std::length_error(logMessage); }