jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix icon fetching

Browse Source 
Reviewed By: nikoant

Differential Revision: D28505372

fbshipit-source-id: e0b001ae56cd9014bd830630ae354ad4d76c2588
This commit is contained in:
Pascal Hartig
2021-05-18 03:44:46 -07:00
committed by Facebook GitHub Bot
parent d8539102d9
commit 6e206fc054
3 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
desktop/app/src/chrome/plugin-manager/__tests__/__snapshots__/PluginInstaller.node.tsx.snap
View File

@@ -144,10 +144,10 @@ exports[`load PluginInstaller list 1`] = `
href="https://yarnpkg.com/en/package/flipper-plugin-hello" href="https://yarnpkg.com/en/package/flipper-plugin-hello"
> >
<div <div
class="css-1tfjvvq-ColoredIconCustom e528dze0" class="css-5r6dd6-ColoredIconCustom e528dze0"
color="#bec2c9" color="#bec2c9"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x"
/> />
</a> </a>
</div> </div>
@@ -214,10 +214,10 @@ exports[`load PluginInstaller list 1`] = `
href="https://yarnpkg.com/en/package/flipper-plugin-world" href="https://yarnpkg.com/en/package/flipper-plugin-world"
> >
<div <div
class="css-1tfjvvq-ColoredIconCustom e528dze0" class="css-5r6dd6-ColoredIconCustom e528dze0"
color="#bec2c9" color="#bec2c9"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x"
/> />
</a> </a>
</div> </div>
@@ -259,7 +259,7 @@ exports[`load PluginInstaller list 1`] = `
alt="dots-3-circle" alt="dots-3-circle"
class="ersmi543 css-6iptsk-ColoredIconBlack-CenteredGlyph e528dze1" class="ersmi543 css-6iptsk-ColoredIconBlack-CenteredGlyph e528dze1"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=dots-3-circle&variant=outline&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=dots-3-circle&variant=outline&size=16&set=facebook_icons&density=1x"
title="Open file selection dialog" title="Open file selection dialog"
/> />
</div> </div>
@@ -270,10 +270,10 @@ exports[`load PluginInstaller list 1`] = `
class="css-auhar3-TooltipContainer e1abcqbd0" class="css-auhar3-TooltipContainer e1abcqbd0"
> >
<div <div
class="ersmi543 css-1vos16e-ColoredIconCustom-CenteredGlyph e528dze0" class="ersmi543 css-1qsl9s4-ColoredIconCustom-CenteredGlyph e528dze0"
color="#D79651" color="#D79651"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=caution-triangle&variant=filled&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=caution-triangle&variant=filled&size=16&set=facebook_icons&density=1x"
/> />
</div> </div>
</div> </div>
@@ -446,10 +446,10 @@ exports[`load PluginInstaller list with one plugin installed 1`] = `
href="https://yarnpkg.com/en/package/flipper-plugin-hello" href="https://yarnpkg.com/en/package/flipper-plugin-hello"
> >
<div <div
class="css-1tfjvvq-ColoredIconCustom e528dze0" class="css-5r6dd6-ColoredIconCustom e528dze0"
color="#bec2c9" color="#bec2c9"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x"
/> />
</a> </a>
</div> </div>
@@ -516,10 +516,10 @@ exports[`load PluginInstaller list with one plugin installed 1`] = `
href="https://yarnpkg.com/en/package/flipper-plugin-world" href="https://yarnpkg.com/en/package/flipper-plugin-world"
> >
<div <div
class="css-1tfjvvq-ColoredIconCustom e528dze0" class="css-5r6dd6-ColoredIconCustom e528dze0"
color="#bec2c9" color="#bec2c9"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=info-circle&variant=filled&size=16&set=facebook_icons&density=1x"
/> />
</a> </a>
</div> </div>
@@ -561,7 +561,7 @@ exports[`load PluginInstaller list with one plugin installed 1`] = `
alt="dots-3-circle" alt="dots-3-circle"
class="ersmi543 css-6iptsk-ColoredIconBlack-CenteredGlyph e528dze1" class="ersmi543 css-6iptsk-ColoredIconBlack-CenteredGlyph e528dze1"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=dots-3-circle&variant=outline&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=dots-3-circle&variant=outline&size=16&set=facebook_icons&density=1x"
title="Open file selection dialog" title="Open file selection dialog"
/> />
</div> </div>
@@ -572,10 +572,10 @@ exports[`load PluginInstaller list with one plugin installed 1`] = `
class="css-auhar3-TooltipContainer e1abcqbd0" class="css-auhar3-TooltipContainer e1abcqbd0"
> >
<div <div
class="ersmi543 css-1vos16e-ColoredIconCustom-CenteredGlyph e528dze0" class="ersmi543 css-1qsl9s4-ColoredIconCustom-CenteredGlyph e528dze0"
color="#D79651" color="#D79651"
size="16" size="16"
src="https://external.xx.fbcdn.net/assets/?name=caution-triangle&variant=filled&size=16&set=facebook_icons&density=1x" src="https://facebook.com/assets/?name=caution-triangle&variant=filled&size=16&set=facebook_icons&density=1x"
/> />
</div> </div>
</div> </div>

4
desktop/app/src/utils/__tests__/icons.node.ts
View File

@@ -23,13 +23,13 @@ test('outline icons get correct local path', () => {
test('filled icons get correct URL', () => { test('filled icons get correct URL', () => {
const iconUrl = buildIconURL('star', 12, 2); const iconUrl = buildIconURL('star', 12, 2);
expect(iconUrl).toBe( expect(iconUrl).toBe(
'https://external.xx.fbcdn.net/assets/?name=star&variant=filled&size=12&set=facebook_icons&density=2x', 'https://facebook.com/assets/?name=star&variant=filled&size=12&set=facebook_icons&density=2x',
); );
}); });
test('outline icons get correct URL', () => { test('outline icons get correct URL', () => {
const iconUrl = buildIconURL('star-outline', 12, 2); const iconUrl = buildIconURL('star-outline', 12, 2);
expect(iconUrl).toBe( expect(iconUrl).toBe(
'https://external.xx.fbcdn.net/assets/?name=star&variant=outline&size=12&set=facebook_icons&density=2x', 'https://facebook.com/assets/?name=star&variant=outline&size=12&set=facebook_icons&density=2x',
); );
}); });

2
desktop/app/src/utils/icons.ts
View File

@@ -69,7 +69,7 @@ export function buildLocalIconURL(name: string, size: number, density: number) {
export function buildIconURL(name: string, size: number, density: number) { export function buildIconURL(name: string, size: number, density: number) {
const icon = getIconPartsFromName(name); const icon = getIconPartsFromName(name);
// eslint-disable-next-line prettier/prettier // eslint-disable-next-line prettier/prettier
const url = `https://external.xx.fbcdn.net/assets/?name=${ const url = `https://facebook.com/assets/?name=${
icon.trimmedName icon.trimmedName
}&variant=${ }&variant=${
icon.variant icon.variant