Rename recordSuccessMetric to reportPlatformFailures

Summary: Change from `recordSuccessMetric` to `reportPlatformFailures`, because the next diff adds `reportPluginFailures` and I want to distinguish the two.

Reviewed By: passy

Differential Revision: D13878380

fbshipit-source-id: 9c6b8bfe1ed2e1a8bbe5aacbec31d24e9aa39171

src/utils/CertificateProvider.js

@@ -21,7 +21,7 @@ const tmp = require('tmp');
 const tmpFile = promisify(tmp.file);
 const tmpDir = promisify(tmp.dir);
 import iosUtil from '../fb-stubs/iOSContainerUtility';
-import {recordSuccessMetric} from './metrics';
+import {reportPlatformFailures} from './metrics';
 
 // Desktop file paths
 const os = require('os');
@@ -78,7 +78,7 @@ export default class CertificateProvider {
   constructor(server: Server, logger: LogManager) {
     this.logger = logger;
     this.adb = adb.createClient();
-    this.certificateSetup = recordSuccessMetric(
+    this.certificateSetup = reportPlatformFailures(
       this.ensureServerCertExists(),
       'ensureServerCertExists',
     );

src/utils/metrics.js

@@ -12,7 +12,7 @@ import {getInstance} from '../fb-stubs/Logger';
  failure state of it, with a given name, based on whether it's fulfilled or
  rejected.
  */
-export function recordSuccessMetric(
+export function reportPlatformFailures(
   promise: Promise<*>,
   name: string,
 ): Promise<*> {