Move plugin stats to their own file
Summary: Really nothing interesting to see here , just moved pluginStats out of messageQueue, as it started there and kept growing Reviewed By: nikoant Differential Revision: D22257318 fbshipit-source-id: 26be7efb4629fcef1b14de96a2b60f17f7d76785
This commit is contained in:
Michel Weststrate
committed by
Facebook GitHub Bot
Facebook GitHub Bot
parent
ec85dd5b01
commit
6c79408b0f
@@ -17,7 +17,7 @@ import Client from '../Client';
|
||||
import {
|
||||
getPluginBackgroundStats,
|
||||
resetPluginBackgroundStatsDelta,
|
||||
} from '../utils/messageQueue';
|
||||
} from '../utils/pluginStats';
|
||||
import {
|
||||
clearTimeline,
|
||||
TrackingEvent,
|
||||
|
||||
@@ -23,123 +23,9 @@ import {
|
||||
import {Idler, BaseIdler} from './Idler';
|
||||
import {pluginIsStarred, getSelectedPluginKey} from '../reducers/connections';
|
||||
import {deconstructPluginKey} from './clientUtils';
|
||||
import {onBytesReceived} from '../dispatcher/tracking';
|
||||
import {defaultEnabledBackgroundPlugins} from './pluginUtils';
|
||||
import {SandyPluginDefinition} from 'flipper-plugin';
|
||||
|
||||
const MAX_BACKGROUND_TASK_TIME = 25;
|
||||
|
||||
type StatEntry = {
|
||||
cpuTimeTotal: number; // Total time spend in persisted Reducer
|
||||
cpuTimeDelta: number; // Time spend since previous tracking tick
|
||||
messageCountTotal: number; // amount of message received for this plugin
|
||||
messageCountDelta: number; // amout of messages received since previous tracking tick
|
||||
maxTime: number; // maximum time spend in a single reducer call
|
||||
bytesReceivedTotal: number; // Bytes received
|
||||
bytesReceivedDelta: number; // Bytes received since last tick
|
||||
};
|
||||
|
||||
const pluginBackgroundStats = new Map<string, StatEntry>();
|
||||
|
||||
export function resetPluginBackgroundStatsDelta() {
|
||||
pluginBackgroundStats.forEach((stat) => {
|
||||
stat.cpuTimeDelta = 0;
|
||||
stat.messageCountDelta = 0;
|
||||
stat.bytesReceivedDelta = 0;
|
||||
});
|
||||
}
|
||||
|
||||
onBytesReceived((plugin: string, bytes: number) => {
|
||||
if (!pluginBackgroundStats.has(plugin)) {
|
||||
pluginBackgroundStats.set(plugin, createEmptyStat());
|
||||
}
|
||||
const stat = pluginBackgroundStats.get(plugin)!;
|
||||
stat.bytesReceivedTotal += bytes;
|
||||
stat.bytesReceivedDelta += bytes;
|
||||
});
|
||||
|
||||
export function getPluginBackgroundStats(): {
|
||||
cpuTime: number; // amount of ms cpu used since the last stats (typically every minute)
|
||||
bytesReceived: number;
|
||||
byPlugin: {[plugin: string]: StatEntry};
|
||||
} {
|
||||
let cpuTime: number = 0;
|
||||
let bytesReceived: number = 0;
|
||||
const byPlugin = Array.from(pluginBackgroundStats.entries()).reduce(
|
||||
(aggregated, [pluginName, data]) => {
|
||||
cpuTime += data.cpuTimeDelta;
|
||||
bytesReceived += data.bytesReceivedDelta;
|
||||
aggregated[pluginName] = data;
|
||||
return aggregated;
|
||||
},
|
||||
{} as {[plugin: string]: StatEntry},
|
||||
);
|
||||
return {
|
||||
cpuTime,
|
||||
bytesReceived,
|
||||
byPlugin,
|
||||
};
|
||||
}
|
||||
|
||||
if (window) {
|
||||
// @ts-ignore
|
||||
window.flipperPrintPluginBackgroundStats = () => {
|
||||
console.table(
|
||||
Array.from(pluginBackgroundStats.entries()).map(
|
||||
([
|
||||
plugin,
|
||||
{
|
||||
cpuTimeDelta,
|
||||
cpuTimeTotal,
|
||||
messageCountDelta,
|
||||
messageCountTotal,
|
||||
maxTime,
|
||||
bytesReceivedTotal,
|
||||
bytesReceivedDelta,
|
||||
},
|
||||
]) => ({
|
||||
plugin,
|
||||
cpuTimeTotal,
|
||||
messageCountTotal,
|
||||
cpuTimeDelta,
|
||||
messageCountDelta,
|
||||
maxTime,
|
||||
bytesReceivedTotal,
|
||||
bytesReceivedDelta,
|
||||
}),
|
||||
),
|
||||
);
|
||||
};
|
||||
}
|
||||
|
||||
function createEmptyStat(): StatEntry {
|
||||
return {
|
||||
cpuTimeDelta: 0,
|
||||
cpuTimeTotal: 0,
|
||||
messageCountDelta: 0,
|
||||
messageCountTotal: 0,
|
||||
maxTime: 0,
|
||||
bytesReceivedTotal: 0,
|
||||
bytesReceivedDelta: 0,
|
||||
};
|
||||
}
|
||||
|
||||
function addBackgroundStat(plugin: string, cpuTime: number) {
|
||||
if (!pluginBackgroundStats.has(plugin)) {
|
||||
pluginBackgroundStats.set(plugin, createEmptyStat());
|
||||
}
|
||||
const stat = pluginBackgroundStats.get(plugin)!;
|
||||
stat.cpuTimeDelta += cpuTime;
|
||||
stat.cpuTimeTotal += cpuTime;
|
||||
stat.messageCountDelta += 1;
|
||||
stat.messageCountTotal += 1;
|
||||
stat.maxTime = Math.max(stat.maxTime, cpuTime);
|
||||
if (cpuTime > MAX_BACKGROUND_TASK_TIME) {
|
||||
console.warn(
|
||||
`Plugin ${plugin} took too much time while doing background: ${cpuTime}ms. Handling background messages should take less than ${MAX_BACKGROUND_TASK_TIME}ms.`,
|
||||
);
|
||||
}
|
||||
}
|
||||
import {addBackgroundStat} from './pluginStats';
|
||||
|
||||
function processMessage(
|
||||
state: State,
|
||||
|
||||
123
desktop/app/src/utils/pluginStats.tsx
Normal file
123
desktop/app/src/utils/pluginStats.tsx
Normal file
@@ -0,0 +1,123 @@
|
||||
/**
|
||||
* Copyright (c) Facebook, Inc. and its affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*
|
||||
* @format
|
||||
*/
|
||||
|
||||
import {onBytesReceived} from '../dispatcher/tracking';
|
||||
|
||||
type StatEntry = {
|
||||
cpuTimeTotal: number; // Total time spend in persisted Reducer
|
||||
cpuTimeDelta: number; // Time spend since previous tracking tick
|
||||
messageCountTotal: number; // amount of message received for this plugin
|
||||
messageCountDelta: number; // amout of messages received since previous tracking tick
|
||||
maxTime: number; // maximum time spend in a single reducer call
|
||||
bytesReceivedTotal: number; // Bytes received
|
||||
bytesReceivedDelta: number; // Bytes received since last tick
|
||||
};
|
||||
|
||||
const MAX_BACKGROUND_TASK_TIME = 25;
|
||||
const pluginBackgroundStats = new Map<string, StatEntry>();
|
||||
|
||||
export function resetPluginBackgroundStatsDelta() {
|
||||
pluginBackgroundStats.forEach((stat) => {
|
||||
stat.cpuTimeDelta = 0;
|
||||
stat.messageCountDelta = 0;
|
||||
stat.bytesReceivedDelta = 0;
|
||||
});
|
||||
}
|
||||
|
||||
onBytesReceived((plugin: string, bytes: number) => {
|
||||
if (!pluginBackgroundStats.has(plugin)) {
|
||||
pluginBackgroundStats.set(plugin, createEmptyStat());
|
||||
}
|
||||
const stat = pluginBackgroundStats.get(plugin)!;
|
||||
stat.bytesReceivedTotal += bytes;
|
||||
stat.bytesReceivedDelta += bytes;
|
||||
});
|
||||
|
||||
export function getPluginBackgroundStats(): {
|
||||
cpuTime: number; // amount of ms cpu used since the last stats (typically every minute)
|
||||
bytesReceived: number;
|
||||
byPlugin: {[plugin: string]: StatEntry};
|
||||
} {
|
||||
let cpuTime: number = 0;
|
||||
let bytesReceived: number = 0;
|
||||
const byPlugin = Array.from(pluginBackgroundStats.entries()).reduce(
|
||||
(aggregated, [pluginName, data]) => {
|
||||
cpuTime += data.cpuTimeDelta;
|
||||
bytesReceived += data.bytesReceivedDelta;
|
||||
aggregated[pluginName] = data;
|
||||
return aggregated;
|
||||
},
|
||||
{} as {[plugin: string]: StatEntry},
|
||||
);
|
||||
return {
|
||||
cpuTime,
|
||||
bytesReceived,
|
||||
byPlugin,
|
||||
};
|
||||
}
|
||||
|
||||
if (window) {
|
||||
// @ts-ignore
|
||||
window.flipperPrintPluginBackgroundStats = () => {
|
||||
console.table(
|
||||
Array.from(pluginBackgroundStats.entries()).map(
|
||||
([
|
||||
plugin,
|
||||
{
|
||||
cpuTimeDelta,
|
||||
cpuTimeTotal,
|
||||
messageCountDelta,
|
||||
messageCountTotal,
|
||||
maxTime,
|
||||
bytesReceivedTotal,
|
||||
bytesReceivedDelta,
|
||||
},
|
||||
]) => ({
|
||||
plugin,
|
||||
cpuTimeTotal,
|
||||
messageCountTotal,
|
||||
cpuTimeDelta,
|
||||
messageCountDelta,
|
||||
maxTime,
|
||||
bytesReceivedTotal,
|
||||
bytesReceivedDelta,
|
||||
}),
|
||||
),
|
||||
);
|
||||
};
|
||||
}
|
||||
|
||||
function createEmptyStat(): StatEntry {
|
||||
return {
|
||||
cpuTimeDelta: 0,
|
||||
cpuTimeTotal: 0,
|
||||
messageCountDelta: 0,
|
||||
messageCountTotal: 0,
|
||||
maxTime: 0,
|
||||
bytesReceivedTotal: 0,
|
||||
bytesReceivedDelta: 0,
|
||||
};
|
||||
}
|
||||
|
||||
export function addBackgroundStat(plugin: string, cpuTime: number) {
|
||||
if (!pluginBackgroundStats.has(plugin)) {
|
||||
pluginBackgroundStats.set(plugin, createEmptyStat());
|
||||
}
|
||||
const stat = pluginBackgroundStats.get(plugin)!;
|
||||
stat.cpuTimeDelta += cpuTime;
|
||||
stat.cpuTimeTotal += cpuTime;
|
||||
stat.messageCountDelta += 1;
|
||||
stat.messageCountTotal += 1;
|
||||
stat.maxTime = Math.max(stat.maxTime, cpuTime);
|
||||
if (cpuTime > MAX_BACKGROUND_TASK_TIME) {
|
||||
console.warn(
|
||||
`Plugin ${plugin} took too much time while doing background: ${cpuTime}ms. Handling background messages should take less than ${MAX_BACKGROUND_TASK_TIME}ms.`,
|
||||
);
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user