jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Export data for the universal export as a single zip archive

Browse Source 
Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/edit#

It is better UX not to prompt a user multiple times to save various pieces of the debug export

Reviewed By: passy

Differential Revision: D40550084

fbshipit-source-id: 51ea3acee7daf5074682219020e1e1eed2182b7d
This commit is contained in:
Andrey Goncharov
2022-10-25 05:31:48 -07:00
committed by Facebook GitHub Bot
parent 821bf2b5b7
commit 6af6652ab2
6 changed files with 92 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
desktop/flipper-ui-core/src/utils/exportData.tsx
View File

@@ -8,7 +8,7 @@
*/
import * as React from 'react';
import {getLogger} from 'flipper-common';
import {getLogger, DeviceDebugFile, DeviceDebugCommand} from 'flipper-common';
import {Store, MiddlewareAPI} from '../reducers';
import {DeviceExport} from 'flipper-frontend-core';
import {selectedPlugins, State as PluginsState} from '../reducers/plugins';
@@ -33,6 +33,8 @@ import ExportDataPluginSheet from '../chrome/ExportDataPluginSheet';
import {getRenderHostInstance} from 'flipper-frontend-core';
import {uploadFlipperMedia} from '../fb-stubs/user';
import {exportLogs} from '../chrome/ConsoleLogs';
import JSZip from 'jszip';
import {safeFilename} from './safeFilename';
export const IMPORT_FLIPPER_TRACE_EVENT = 'import-flipper-trace';
export const EXPORT_FLIPPER_TRACE_EVENT = 'export-flipper-trace';
@@ -612,25 +614,50 @@ export async function startFlipperLogsExport() {
await getRenderHostInstance().exportFile?.(serializedLogs);
}
export async function startClientLogsExport() {
const _clientLogs = await getRenderHostInstance().flipperServer.exec(
'fetch-debug-data',
);
// TODO: Save all log files
async function startDeviceFlipperFolderExport() {
return await getRenderHostInstance().flipperServer.exec('fetch-debug-data');
}
export async function exportEverythingEverywhereAllAtOnce(
store: MiddlewareAPI,
) {
// TODO: Show a progress dialog
// TODO: Pack all files in a single archive
const zip = new JSZip();
// Step 1: Export Flipper logs
await startFlipperLogsExport();
const serializedLogs = exportLogs
.map((item) => JSON.stringify(item))
.join('\n');
zip.file('flipper_logs.txt', serializedLogs);
// Step 2: Export device logs
await startClientLogsExport();
const flipperFolderContent = await startDeviceFlipperFolderExport();
const deviceFlipperFolder = zip.folder('device_flipper_folder')!;
flipperFolderContent.forEach((deviceDebugItem) => {
const deviceAppFolder = deviceFlipperFolder.folder(
safeFilename(`${deviceDebugItem.serial}__${deviceDebugItem.appId}`),
)!;
deviceDebugItem.data.forEach((appDebugItem) => {
const appDebugItemIsFile = (
item: DeviceDebugFile | DeviceDebugCommand,
): item is DeviceDebugFile => !!(appDebugItem as DeviceDebugFile).path;
if (appDebugItemIsFile(appDebugItem)) {
deviceAppFolder.file(
safeFilename(appDebugItem.path),
appDebugItem.data,
);
} else {
deviceAppFolder.file(
safeFilename(appDebugItem.command),
appDebugItem.result,
);
}
});
});
// Step 3: Export Flipper State
// TODO: Export all plugins automatically
@@ -642,7 +669,12 @@ export async function exportEverythingEverywhereAllAtOnce(
// need to be cleaned up later in combination with SupportForm
store.dispatch(selectedPlugins(plugins));
const {serializedString} = await exportStore(store);
await getRenderHostInstance().exportFile?.(serializedString);
zip.file('flipper_export', serializedString);
const archiveData = await zip.generateAsync({type: 'uint8array'});
await getRenderHostInstance().exportFileBinary?.(archiveData);
}
export async function startFileExport(dispatch: Store['dispatch']) {