jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use download file API in MobileBuildsPlugin

Browse Source 
Summary:
Facenook:
Use downloadFile API in Mobile Builds plugin

Reviewed By: mweststrate

Differential Revision: D32922041

fbshipit-source-id: d554ed9287af3bda4329e87732ab4de67136c0d2
This commit is contained in:
Andrey Goncharov
2021-12-10 06:34:37 -08:00
committed by Facebook GitHub Bot
parent 92f0ed67f4
commit 6aa0cef927
3 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
desktop/flipper-server-core/src/FlipperServerImpl.tsx
View File

@@ -44,8 +44,10 @@ import {
internGraphPOSTAPIRequest, internGraphPOSTAPIRequest,
} from './fb-stubs/internRequests'; } from './fb-stubs/internRequests';
import {commandNodeApiExec} from './commands/NodeApiExec'; import {commandNodeApiExec} from './commands/NodeApiExec';
import {access, copyFile, mkdir, unlink} from 'fs/promises';
import {commandDownloadFileStartFactory} from './commands/DownloadFile'; import {commandDownloadFileStartFactory} from './commands/DownloadFile';
import {promises} from 'fs';
const {access, copyFile, mkdir, unlink} = promises;
export const SERVICE_FLIPPER = 'flipper.oAuthToken'; export const SERVICE_FLIPPER = 'flipper.oAuthToken';

5
desktop/flipper-server-core/src/commands/DownloadFile.tsx
View File

@@ -55,7 +55,10 @@ export const commandDownloadFileStartFactory =
maxRedirects, maxRedirects,
headers, headers,
}); });
const totalSize = response.headers['content-length'] ?? 0; let totalSize = parseInt(response.headers['content-length'], 10);
if (Number.isNaN(totalSize)) {
totalSize = 0;
}
const writeStream = response.data.pipe( const writeStream = response.data.pipe(
createWriteStream(dest, {autoClose: true}), createWriteStream(dest, {autoClose: true}),

4
desktop/plugins/public/reactdevtools/index.tsx
View File

@@ -22,7 +22,7 @@ import {
import React from 'react'; import React from 'react';
import getPort from 'get-port'; import getPort from 'get-port';
import {Button, message, Switch, Typography, Select} from 'antd'; import {Button, message, Switch, Typography, Select} from 'antd';
import fs from 'fs/promises'; import fs from 'fs';
import {DevToolsEmbedder} from './DevToolsEmbedder'; import {DevToolsEmbedder} from './DevToolsEmbedder';
import {getInternalDevToolsModule} from './fb-stubs/getInternalDevToolsModule'; import {getInternalDevToolsModule} from './fb-stubs/getInternalDevToolsModule';
@@ -42,7 +42,7 @@ async function findGlobalDevTools(): Promise<string | undefined> {
'node_modules', 'node_modules',
'react-devtools-core', 'react-devtools-core',
); );
await fs.stat(devToolsPath); await fs.promises.stat(devToolsPath);
return devToolsPath; return devToolsPath;
} catch (error) { } catch (error) {
console.warn('Failed to find globally installed React DevTools: ' + error); console.warn('Failed to find globally installed React DevTools: ' + error);