From 6a22d6dca97b60ae8db44c4828d372964e7e0233 Mon Sep 17 00:00:00 2001 From: Dustin Shahidehpour Date: Wed, 7 Oct 2020 15:40:39 -0700 Subject: [PATCH] Add docs to SKSubDesciptor Summary: This tripped me up for a bit. Add some docs. Reviewed By: Andrey-Mishanin Differential Revision: D24160934 fbshipit-source-id: a36ac6b205a9edeeb0698f44476456583146907c --- .../FlipperKitLayoutComponentKitSupport/SKSubDescriptor.h | 3 +++ .../FlipperKitLayoutComponentKitSupport/SKSubDescriptor.mm | 6 ------ 2 files changed, 3 insertions(+), 6 deletions(-) delete mode 100644 iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.mm diff --git a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.h b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.h index 95cb30924..d2045d2a3 100644 --- a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.h +++ b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.h @@ -13,5 +13,8 @@ A SKSubDescriptor is a function which knows how to expose additional data to SKLayoutDescriptor. This class is for frameworks wanting to pass data along through the Layout Descriptor. + + The infra expects that the string returned is a JSON string. + For example: @"{\'key\': 5}" */ typedef NSString* (*SKSubDescriptor)(SKComponentLayoutWrapper* node); diff --git a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.mm b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.mm deleted file mode 100644 index 8ecfd7c25..000000000 --- a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKSubDescriptor.mm +++ /dev/null @@ -1,6 +0,0 @@ -/* - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */