diff --git a/desktop/app/src/chrome/RatingButton.tsx b/desktop/app/src/chrome/RatingButton.tsx index 86f6a58e3..172e449b8 100644 --- a/desktop/app/src/chrome/RatingButton.tsx +++ b/desktop/app/src/chrome/RatingButton.tsx @@ -223,7 +223,7 @@ class FeedbackComponent extends Component< onKeyDown={(e) => e.key == 'Enter' && this.onCommentSubmitted(this.state.comment) } - autoFocus={true} + autoFocus /> , diff --git a/desktop/app/src/chrome/SettingsSheet.tsx b/desktop/app/src/chrome/SettingsSheet.tsx index 1ea0cfc05..546d0864c 100644 --- a/desktop/app/src/chrome/SettingsSheet.tsx +++ b/desktop/app/src/chrome/SettingsSheet.tsx @@ -191,7 +191,7 @@ class SettingsSheet extends Component { { this.setState({ updatedSettings: {...this.state.updatedSettings, idbPath: v}, diff --git a/desktop/app/src/chrome/ShareSheetErrorList.tsx b/desktop/app/src/chrome/ShareSheetErrorList.tsx index c1534e188..e4e16e138 100644 --- a/desktop/app/src/chrome/ShareSheetErrorList.tsx +++ b/desktop/app/src/chrome/ShareSheetErrorList.tsx @@ -48,7 +48,7 @@ export default class Popover extends PureComponent { return null; } return ( - + {this.props.title} {this.props.errors.map((e: Error, index) => ( diff --git a/desktop/app/src/chrome/VideoRecordingButton.tsx b/desktop/app/src/chrome/VideoRecordingButton.tsx index 3f231a2d6..5d899238f 100644 --- a/desktop/app/src/chrome/VideoRecordingButton.tsx +++ b/desktop/app/src/chrome/VideoRecordingButton.tsx @@ -81,7 +81,7 @@ export default class VideoRecordingButton extends Component { const {selectedDevice} = this.props; return ( } /> {this.renderSidebar()} diff --git a/desktop/app/src/plugins/TableNativePlugin.tsx b/desktop/app/src/plugins/TableNativePlugin.tsx index b3637ba4b..efb233787 100644 --- a/desktop/app/src/plugins/TableNativePlugin.tsx +++ b/desktop/app/src/plugins/TableNativePlugin.tsx @@ -124,7 +124,7 @@ function renderValue({type, value}: {type: string; value: any}) { switch (type) { case 'boolean': return ( - + {value.toString()} ); @@ -232,7 +232,7 @@ function renderSidebarSection( case 'json': return ( - + ); case 'toolbar': @@ -240,7 +240,7 @@ function renderSidebarSection( default: return ( - + ); } @@ -480,20 +480,20 @@ export default function createTableNativePlugin(id: string, title: string) { : null; return ( - + {topToolbarComponent} Clear Table} /> {this.renderSidebar()} diff --git a/desktop/app/src/ui/components/ButtonGroup.tsx b/desktop/app/src/ui/components/ButtonGroup.tsx index 8ff111f08..8d8f1ece8 100644 --- a/desktop/app/src/ui/components/ButtonGroup.tsx +++ b/desktop/app/src/ui/components/ButtonGroup.tsx @@ -36,7 +36,7 @@ export const ButtonGroupContext = createContext(false); */ export default function ButtonGroup({children}: {children: React.ReactNode}) { return ( - + {children} ); diff --git a/desktop/app/src/ui/components/ButtonGroupChain.tsx b/desktop/app/src/ui/components/ButtonGroupChain.tsx index 0e7dfccc1..918f45f5a 100644 --- a/desktop/app/src/ui/components/ButtonGroupChain.tsx +++ b/desktop/app/src/ui/components/ButtonGroupChain.tsx @@ -72,7 +72,7 @@ type Props = { */ export default function ButtonGroupChain({children, iconSize, icon}: Props) { return ( - + {React.Children.map(children, (child, idx) => { if (idx === 0) { diff --git a/desktop/app/src/ui/components/ErrorBoundary.tsx b/desktop/app/src/ui/components/ErrorBoundary.tsx index 880453c16..f2b45a9a9 100644 --- a/desktop/app/src/ui/components/ErrorBoundary.tsx +++ b/desktop/app/src/ui/components/ErrorBoundary.tsx @@ -76,7 +76,7 @@ export default class ErrorBoundary extends Component< } return ( - + {heading} {this.props.showStack !== false && ( diff --git a/desktop/app/src/ui/components/FileSelector.tsx b/desktop/app/src/ui/components/FileSelector.tsx index b87e426d5..94bbaf66f 100644 --- a/desktop/app/src/ui/components/FileSelector.tsx +++ b/desktop/app/src/ui/components/FileSelector.tsx @@ -91,7 +91,7 @@ export default function FileSelector({ { if (e.dataTransfer.files.length) { onChange(e.dataTransfer.files[0].path); diff --git a/desktop/app/src/ui/components/StackTrace.tsx b/desktop/app/src/ui/components/StackTrace.tsx index 0cf678c46..312d2564a 100644 --- a/desktop/app/src/ui/components/StackTrace.tsx +++ b/desktop/app/src/ui/components/StackTrace.tsx @@ -188,7 +188,7 @@ export default class StackTrace extends Component<{ + {before} {tabList} diff --git a/desktop/app/src/ui/components/TabsContainer.tsx b/desktop/app/src/ui/components/TabsContainer.tsx index 507642052..70de082ab 100644 --- a/desktop/app/src/ui/components/TabsContainer.tsx +++ b/desktop/app/src/ui/components/TabsContainer.tsx @@ -26,7 +26,7 @@ export const TabsContext = React.createContext(true); export default function TabsContainer(props: {children: any}) { return ( - {props.children} + {props.children} ); } diff --git a/desktop/app/src/ui/components/VirtualList.tsx b/desktop/app/src/ui/components/VirtualList.tsx index 9bb46be69..aed70fa14 100644 --- a/desktop/app/src/ui/components/VirtualList.tsx +++ b/desktop/app/src/ui/components/VirtualList.tsx @@ -133,11 +133,7 @@ export default class VirtualList extends Component< } return ( - + {inner} ); diff --git a/desktop/app/src/ui/components/elements-inspector/sidebar.tsx b/desktop/app/src/ui/components/elements-inspector/sidebar.tsx index 04bf3eca9..a25228f76 100644 --- a/desktop/app/src/ui/components/elements-inspector/sidebar.tsx +++ b/desktop/app/src/ui/components/elements-inspector/sidebar.tsx @@ -66,8 +66,8 @@ class InspectorSidebarSection extends Component { data={this.props.data} setValue={this.props.onValueChanged ? this.setValue : undefined} extractValue={this.extractValue} - expandRoot={true} - collapsed={true} + expandRoot + collapsed tooltips={this.props.tooltips} /> diff --git a/desktop/app/src/ui/components/table/TableHead.tsx b/desktop/app/src/ui/components/table/TableHead.tsx index 214e78312..a321d5535 100644 --- a/desktop/app/src/ui/components/table/TableHead.tsx +++ b/desktop/app/src/ui/components/table/TableHead.tsx @@ -178,7 +178,7 @@ class TableHeadColumn extends PureComponent<{ if (isResizable) { children = ( diff --git a/desktop/flipper-plugin/src/ui/data-inspector/__tests__/DataInspector.node.tsx b/desktop/flipper-plugin/src/ui/data-inspector/__tests__/DataInspector.node.tsx index 0a0f3809d..5604c1e8c 100644 --- a/desktop/flipper-plugin/src/ui/data-inspector/__tests__/DataInspector.node.tsx +++ b/desktop/flipper-plugin/src/ui/data-inspector/__tests__/DataInspector.node.tsx @@ -32,7 +32,7 @@ test('changing collapsed property works', async () => { res.rerender(); await res.findByText(/cool/); - res.rerender(); + res.rerender(); expect(res.queryAllByText(/cool/).length).toBe(0); }); diff --git a/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx b/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx index 0259d7d73..84153f54d 100644 --- a/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx +++ b/desktop/flipper-plugin/src/ui/data-table/TableHead.tsx @@ -210,7 +210,7 @@ function TableHeadColumn({ if (isResizable) { children = ( diff --git a/desktop/plugins/public/cpu/TemperatureTable.tsx b/desktop/plugins/public/cpu/TemperatureTable.tsx index 69de98328..1bd589432 100644 --- a/desktop/plugins/public/cpu/TemperatureTable.tsx +++ b/desktop/plugins/public/cpu/TemperatureTable.tsx @@ -62,14 +62,14 @@ export default class TemperatureTable extends Component { render() { return ( ); } diff --git a/desktop/plugins/public/databases/DatabaseDetailSidebar.tsx b/desktop/plugins/public/databases/DatabaseDetailSidebar.tsx index 61e2ac2d4..5b08c8c68 100644 --- a/desktop/plugins/public/databases/DatabaseDetailSidebar.tsx +++ b/desktop/plugins/public/databases/DatabaseDetailSidebar.tsx @@ -81,9 +81,7 @@ function buildSidebarRow(key: string, val: Value): TableRow { var parsed = JSON.parse(val.value); } catch (_error) {} if (parsed) { - output = ( - - ); + output = ; } } return { @@ -186,7 +184,7 @@ export default React.memo(function DatabaseDetailSidebar( ); return ( - + {onSave ? (
diff --git a/desktop/plugins/public/databases/DatabasesPlugin.tsx b/desktop/plugins/public/databases/DatabasesPlugin.tsx index 551c19f29..60a7aab16 100644 --- a/desktop/plugins/public/databases/DatabasesPlugin.tsx +++ b/desktop/plugins/public/databases/DatabasesPlugin.tsx @@ -131,9 +131,9 @@ const QueryHistory = React.memo(({history}: {history: Array}) => { floating={false} columns={columns} columnSizes={{time: 75}} - zebra={true} + zebra rows={rows} - horizontallyScrollable={true} + horizontallyScrollable /> ); @@ -232,12 +232,12 @@ const DataTable = React.memo( }), {}, )} - zebra={true} + zebra rows={page.rows.map((row: Array, index: number) => transformRow(page.columns, row, index), )} - horizontallyScrollable={true} - multiHighlight={true} + horizontallyScrollable + multiHighlight onRowHighlighted={highlightedRowsChanged} onSort={sortOrderChanged} initialSortOrder={currentSort ?? undefined} @@ -281,7 +281,7 @@ const QueryTable = React.memo( ({ key: name, visible: true, @@ -291,11 +291,11 @@ const QueryTable = React.memo( Object.assign({}, acc, {[val]: {value: val, resizable: true}}), {}, )} - zebra={true} + zebra rows={rows.map((row: Array, index: number) => transformRow(columns, row, index), )} - horizontallyScrollable={true} + horizontallyScrollable onRowHighlighted={highlightedRowsChanged} /> {table.highlightedRows.length === 1 && ( diff --git a/desktop/plugins/public/fresco/ImagesCacheOverview.tsx b/desktop/plugins/public/fresco/ImagesCacheOverview.tsx index 17a9df125..d4b163ab7 100644 --- a/desktop/plugins/public/fresco/ImagesCacheOverview.tsx +++ b/desktop/plugins/public/fresco/ImagesCacheOverview.tsx @@ -191,7 +191,7 @@ export default class ImagesCacheOverview extends PureComponent< return ( diff --git a/desktop/plugins/public/fresco/ImagesSidebar.tsx b/desktop/plugins/public/fresco/ImagesSidebar.tsx index 363183249..da36fcf59 100644 --- a/desktop/plugins/public/fresco/ImagesSidebar.tsx +++ b/desktop/plugins/public/fresco/ImagesSidebar.tsx @@ -100,10 +100,7 @@ class EventDetails extends Component<{ const {event} = this.props; return ( - } - floating={false} - padded={true}> + } floating={false} padded>

Attribution : diff --git a/desktop/plugins/public/fresco/index.tsx b/desktop/plugins/public/fresco/index.tsx index 96ca15dab..0c98d432d 100644 --- a/desktop/plugins/public/fresco/index.tsx +++ b/desktop/plugins/public/fresco/index.tsx @@ -115,15 +115,14 @@ export function plugin(client: PluginClient) { message: ( - CloseableReference leaked for{' '} - {event.className} + CloseableReference leaked for {event.className} (identity hashcode: {event.identityHashCode}). - Stacktrace: + Stacktrace: - {event.stacktrace || ''} + {event.stacktrace || ''} ), @@ -466,7 +465,7 @@ function Sidebar() { if (currentSelectedImage == null) { return ( - + Select an image to see the events associated with it. diff --git a/desktop/plugins/public/kaios-allocations/index.tsx b/desktop/plugins/public/kaios-allocations/index.tsx index e20700a56..9fe7490cf 100644 --- a/desktop/plugins/public/kaios-allocations/index.tsx +++ b/desktop/plugins/public/kaios-allocations/index.tsx @@ -390,7 +390,7 @@ export default class AllocationsPlugin extends FlipperDevicePlugin< heading="Page allocations" floating={false} collapsable={false} - grow={true}> + grow> - + Inspector