jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't report an error when Fresco is not initialized yet and Flipper queries data

Browse Source 
Summary:
We shouldn't report an error when Flipper is querying data before Fresco is initialized.
This will be especially useful when we move to lazy Fresco initialization later this year.

Reviewed By: passy

Differential Revision: D33978177

fbshipit-source-id: dfb6cb1b73737adbb557ecb141b043d088b5a574
This commit is contained in:
Alexander Oprisnik
2022-02-03 08:33:12 -08:00
committed by Facebook GitHub Bot
parent 4b6fcb6aaf
commit 6960196d8e
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
android/plugins/fresco/src/main/java/com/facebook/flipper/plugins/fresco/FrescoFlipperPlugin.java
View File

@@ -145,7 +145,7 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
new FlipperReceiver() { new FlipperReceiver() {
@Override @Override
public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception { public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception {
if (!ensureFrescoInitialized(responder)) { if (!ensureFrescoInitialized()) {
return; return;
} }
@@ -166,7 +166,7 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
new FlipperReceiver() { new FlipperReceiver() {
@Override @Override
public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception { public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception {
if (!ensureFrescoInitialized(responder)) { if (!ensureFrescoInitialized()) {
return; return;
} }
@@ -200,7 +200,7 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
@Override @Override
public void onReceive(FlipperObject params, final FlipperResponder responder) public void onReceive(FlipperObject params, final FlipperResponder responder)
throws Exception { throws Exception {
if (!ensureFrescoInitialized(responder)) { if (!ensureFrescoInitialized()) {
return; return;
} }
@@ -325,7 +325,7 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
new FlipperReceiver() { new FlipperReceiver() {
@Override @Override
public void onReceive(FlipperObject params, FlipperResponder responder) { public void onReceive(FlipperObject params, FlipperResponder responder) {
if (!ensureFrescoInitialized(responder)) { if (!ensureFrescoInitialized()) {
return; return;
} }
@@ -349,7 +349,7 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
new FlipperReceiver() { new FlipperReceiver() {
@Override @Override
public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception { public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception {
if (!ensureFrescoInitialized(responder)) { if (!ensureFrescoInitialized()) {
return; return;
} }
@@ -365,7 +365,7 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
new FlipperReceiver() { new FlipperReceiver() {
@Override @Override
public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception { public void onReceive(FlipperObject params, FlipperResponder responder) throws Exception {
if (!ensureFrescoInitialized(responder)) { if (!ensureFrescoInitialized()) {
return; return;
} }
@@ -457,13 +457,12 @@ public class FrescoFlipperPlugin extends BufferingFlipperPlugin
.build(); .build();
} }
private boolean ensureFrescoInitialized(FlipperResponder responder) { private boolean ensureFrescoInitialized() {
mPerfLogger.startMarker("Sonar.Fresco.ensureFrescoInitialized"); mPerfLogger.startMarker("Sonar.Fresco.ensureFrescoInitialized");
try { try {
Fresco.getImagePipelineFactory(); Fresco.getImagePipelineFactory();
return true; return true;
} catch (NullPointerException e) { } catch (NullPointerException e) {
respondError(responder, "Fresco is not initialized yet");
return false; return false;
} finally { } finally {
mPerfLogger.endMarker("Sonar.Fresco.ensureFrescoInitialized"); mPerfLogger.endMarker("Sonar.Fresco.ensureFrescoInitialized");