From 6936cb34acd3c7d9fc79be346cb6dc1560461778 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Fri, 26 May 2023 08:02:12 -0700 Subject: [PATCH] Track socket already in use Summary: Some times the socket can already be in use by an existing process. Track it as to quantify how likely this is found in production. May remove later. Need to answer: - Socket already in use rate over time Reviewed By: antonk52 Differential Revision: D46219768 fbshipit-source-id: 27da82cddb707f729a1d43079e84c221bb544a82 --- desktop/flipper-server-core/src/server/startServer.tsx | 2 +- desktop/flipper-server-core/src/utils/tracker.tsx | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/desktop/flipper-server-core/src/server/startServer.tsx b/desktop/flipper-server-core/src/server/startServer.tsx index 012c60033..3ae19cce4 100644 --- a/desktop/flipper-server-core/src/server/startServer.tsx +++ b/desktop/flipper-server-core/src/server/startServer.tsx @@ -176,7 +176,7 @@ async function startProxyServer( console.warn( `Cannot start flipper-server because socket ${socketPath} is in use.`, ); - // TODO: track socket is in use. + tracker.track('server-socket-already-in-use', {}); } else { console.info(`Cleaning up stale socket ${socketPath}`); await fs.rm(socketPath, {force: true}); diff --git a/desktop/flipper-server-core/src/utils/tracker.tsx b/desktop/flipper-server-core/src/utils/tracker.tsx index ff672aaa6..00cfed71e 100644 --- a/desktop/flipper-server-core/src/utils/tracker.tsx +++ b/desktop/flipper-server-core/src/utils/tracker.tsx @@ -15,6 +15,7 @@ type TrackerEvents = { present: boolean; error?: string; }; + 'server-socket-already-in-use': {}; }; class ServerCoreTracker {